Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unuseful search syntax feedback #7391

Merged
merged 2 commits into from
Feb 1, 2021

Conversation

DominikVoigt
Copy link
Contributor

This PR removes unuseful feedback from the web search text field, as it is not necessary and provides no advantage.
With the introduction of transformers in #7350, the syntax feedback will be adapted and provide adequate and useful feedback.

Fixes #7349, addresses #7277.

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@tobiasdiez
Copy link
Member

I'm against removing the syntax check. From a user perspective, you want to be notified as early as possible that your search query is not valid and not only after you click the search button. Moreover, showing the query syntax problem as some kind of overlay is nicer than a modal error dialog.

That being said, the user experience can indeed be improved. For example, I'm a fan of a more visual representation of the search query as for example in https://dribbble.com/shots/6323387-Job-Search or http://evoluteur.github.io/structured-filter/index.html

@DominikVoigt
Copy link
Contributor Author

DominikVoigt commented Jan 27, 2021

Yeah, I really like the chips design of
I just wanted to disable the current syntax highlighting as it leads to issues.
I will start working on a chips design using the lucene library for tokenization.

@tobiasdiez
Copy link
Member

Nice! Then I would prefer to remove the check in the same PR that also converts to the chip-based design (or in two PRs that are merged directly after each other). Or is the check currently so broken that the fetchers are not useable?

@koppor
Copy link
Member

koppor commented Feb 1, 2021

The issues are:

I believe we can re-add the feedback before a new release (#7411). Assigned the issue to the next milestone.

@koppor koppor merged commit 66a771c into master Feb 1, 2021
@koppor koppor deleted the remove-unusefull-search-syntax-feedback branch February 1, 2021 20:42
@Fu188
Copy link
Contributor

Fu188 commented Feb 3, 2021

I think it is unreasonable to remove the syntax check.

@koppor
Copy link
Member

koppor commented Feb 7, 2021

@Fu188 Please not my comment above:

I believe we can re-add the feedback before a new release (#7411). Assigned the issue to the next milestone.

Only users using a non-released version will have no syntax checks. We will work on #7411. This will be possible with our new query syntax, which will be translated to the fetchers. Currently, the user has to know the differences between IEEE, ACM, arXiv and modify the query when changing the fetcher. With the new infrastructure, JabRef will do the translation for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When typing a "-" after a long title into web search the application freezes
4 participants