Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extends dark theme to group custom-color-picker #7520

Merged
merged 2 commits into from
Mar 13, 2021
Merged

Extends dark theme to group custom-color-picker #7520

merged 2 commits into from
Mar 13, 2021

Conversation

tp-1000
Copy link
Contributor

@tp-1000 tp-1000 commented Mar 12, 2021 •
edited by Siedlerchr
Loading

fixes #7481
Color fix

Dark.css update to extend to the custom color picker
Custom-color-picker background was white instead of dark

Custom-color-picker background is now dark and matches dark theme

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

Screen Shot 2021-03-12 at 1 49 24 PM

@tp-1000
Extends dark theme to group custom-color-picker
fdd8547 
Resolves issue JabRef#7481
Color fix

Dark.css update to extend to the custom color picker
Custom-color-picker background was white instead of dark

Custom-color-picker background is now dark and matches dark theme
Siedlerchr
Siedlerchr approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! LGTM
PRs from contributors require the approval of at least 2 reviewers.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 12, 2021
calixtus
calixtus approved these changes Mar 13, 2021
View reviewed changes
Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, besides some little grammatical issue with the changelog. Fixing it myself and merging. Thank you!

@calixtus calixtus merged commit 153d82d into JabRef:master Mar 13, 2021
Siedlerchr added a commit that referenced this pull request Mar 14, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into master
85389e4 
* upstream/master:
  [create-pull-request] automated change (#7530)
  Fix:Double-click to open a file (#7523)
  Extends dark theme to group custom-color-picker (#7520)
@Siedlerchr
Copy link
Member

@tp-1000 Thanks again, there is still one issue with the dark theme left in this thread #5522 (comment)
Maybe you are interested in this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@calixtus calixtus calixtus approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The "custom colors" window for group color selection loads theme partially
3 participants
@tp-1000 @Siedlerchr @calixtus