Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add corporate proxy workaround for Version.getAllAvailableVersions() #7890

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Add corporate proxy workaround for Version.getAllAvailableVersions() #7890

merged 2 commits into from
Jul 7, 2021

Conversation

koppor
Copy link
Member

@koppor koppor commented Jul 5, 2021 •
edited
Loading

Fixes #7884 by adding a workaround.

Added test won't work on the CI, because of GitHub's rate limit.

java.io.IOException: Server returned HTTP response code: 403 for URL: https://api.github.com/repos/JabRef/JabRef/releases

	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1932)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1528)
	at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:224)
	at org.jabref.logic.util.Version.getAllAvailableVersions(Version.java:99)
	at org.jabref.logic.util.VersionTest.getAllAvailableVersionsReturnsSomething(VersionTest.java:303)
  • [] Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • [] Tests created for changes (if applicable)
  • [] Manually tested changed features in running JabRef (always required)
  • [] Screenshots added in PR description (for UI changes)
  • [] Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

koppor and others added 2 commits July 5, 2021 18:53
@koppor @calixtus @Siedlerchr
Add test for Version.getAllAvailableVersions()
95d3a94 
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
Co-authored-by: Christoph <siedlerkiller@gmail.com>
@koppor @calixtus @Siedlerchr
Add workaround for corporate proxy
ef0b08f 
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
Co-authored-by: Christoph <siedlerkiller@gmail.com>
@koppor koppor changed the title Add test for Version.getAllAvailableVersions() Add corporate proxy workaround for Version.getAllAvailableVersions() Jul 5, 2021
@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jul 5, 2021
@koppor
Copy link
Member Author

koppor commented Jul 7, 2021

I checked it, works for me now.

@Siedlerchr Siedlerchr merged commit b9baa94 into main Jul 7, 2021
@Siedlerchr Siedlerchr deleted the add-test-for-version-check branch July 7, 2021 21:19
Siedlerchr added a commit that referenced this pull request Jul 15, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into jdk17
a798eb5 
* upstream/main: (45 commits)
  Squashed 'buildres/csl/csl-styles/' changes from ec4a4c0..176997d (#7910)
  Update citeproc-java to 3.0.0-alpha.2 (#7911)
  Search in PDF Files (#2838)
  Removed references to apache commons logging (#7907)
  Oobranch c : ootext and rangesort (#7788)
  Bump jackson-datatype-jsr310 from 2.12.3 to 2.12.4 (#7901)
  fix markdownlint
  Bump jackson-dataformat-yaml from 2.12.3 to 2.12.4 (#7899)
  Bump postgresql from 42.2.22 to 42.2.23 (#7902)
  Bump classgraph from 4.8.109 to 4.8.110 (#7900)
  Bump gittools/actions from 0.9.9 to 0.9.10 (#7898)
  Bump flowless from 0.6.3 to 0.6.4 (#7903)
  Bump jsoup from 1.13.1 to 1.14.1 (#7904)
  Bump tika-core from 1.26 to 1.27 (#7897)
  Try even more empty lines to provoke conflicts in CHANGELOG.md after a release
  Fix position in CHANGELOG.md
  Add corporate proxy workaround for Version.getAllAvailableVersions() (#7890)
  Update to Java 16 in build.gradle (#7892)
  Preparing Changelog for the next release cycle
  New development cycle
  ...

# Conflicts:
#	gradle/wrapper/gradle-wrapper.properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: Could not connect to the update server
2 participants
@koppor @Siedlerchr