Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reordered Pdf-Importer priorities #8001

Merged
merged 2 commits into from
Aug 18, 2021
Merged

Reordered Pdf-Importer priorities #8001

merged 2 commits into from
Aug 18, 2021

Conversation

btut
Copy link
Contributor

@btut btut commented Aug 18, 2021 •
edited by calixtus
Loading

Changed the list, that implies priority, of PdfImporters in the PdfMergeMetadataImporter.

Fixes koppor#169

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@btut btut self-assigned this Aug 18, 2021
@btut btut requested review from calixtus and koppor August 18, 2021 19:43
@Siedlerchr Siedlerchr merged commit 5f3abb5 into main Aug 18, 2021
@Siedlerchr Siedlerchr deleted the fixPdfImporterPriorities branch August 18, 2021 20:17
Siedlerchr added a commit that referenced this pull request Aug 20, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into jabrefonline
a56801a 
* upstream/main: (110 commits)
  Extract PushTo names into model (#8005)
  Refactor processCitation in GrobidService to match processPdf (#8003)
  Improved progress indication for fulltext-index operations (#7981)
  Reordered Pdf-Importer priorities (#8001)
  Implement more pdf importers (#7947)
  Adding icon picker for group dialog issue#6142 (#7776)
  Fix possible NPE in exporter with empty charset (#7979)
  Fix icon color (#7994)
  Bump slf4j-api from 2.0.0-alpha2 to 2.0.0-alpha4 (#7991)
  Bump classgraph from 4.8.112 to 4.8.114 (#7990)
  Bump mariadb-java-client from 2.7.3 to 2.7.4 (#7992)
  Bump jsoup from 1.14.1 to 1.14.2 (#7993)
  New yaml issue template (#7983)
  [Bot] Update CSL styles (#7985)
  Reordered items in main table right-click menu (#7952)
  Fulltext Index: Only index local pdf files (#7980)
  Bump WyriHaximus/github-action-wait-for-status from 1.3 to 1.4 (#7973)
  Bump byte-buddy-parent from 1.11.9 to 1.11.12 (#7974)
  Bump classgraph from 4.8.110 to 4.8.112 (#7975)
  Bump checkstyle from 8.45 to 8.45.1 (#7978)
  ...

# Conflicts:
#	src/main/java/module-info.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koppor koppor koppor approved these changes

@calixtus calixtus Awaiting requested review from calixtus

Assignees

@btut btut

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace PDFContentImporter by another library
3 participants
@btut @koppor @Siedlerchr