Observable preferences I (Internal [formerly Version], Groups, Xmp, AutoComplete) #8336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calixtus
added
preferences
status: ready-for-review
Siedlerchr
reviewed
Dec 21, 2021
| } | ||
| EasyBind.subscribe(preferencesService.getGroupsPreferences().displayGroupCountProperty(), | ||
| (newValue) -> { | ||
| if (text.textProperty().isBound()) { |
There was a problem hiding this comment.
Why is this necessary? Please add a comment
There was a problem hiding this comment.
I cannot set the text to an empty value if the value is bound, instead it keeps the last calculated number of entries in group.getHits() or just 0, if the preference option to calculate the number of entries (which is very expensive in large databases) is deactivated. If the calculation of entries is disabled and you add or remove an entry from a group it would display the wrong number of entries.
Siedlerchr
approved these changes
Dec 26, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #8260
Note: enabling autocomplete without restarting probably requires a major refactor of the entry editor. As I believe that this would escalate this PR too much, I think we should leave this for later, maybe when the entry editor is redesigned.
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)