Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the network connection timeout and improve error message #8894

Merged
merged 1 commit into from
Jun 12, 2022
Merged

Increase the network connection timeout and improve error message #8894

merged 1 commit into from
Jun 12, 2022

Commits on Jun 11, 2022

  1. Increase the network connection timeout and improve error message

    In some instances, connecting to an existing JabRef instance may take longer
    than the original 200ms timeout. Here we increase that timeout to a full
    second. If it takes longer than that to connect to an existing instance,
    chances are something else bad is going on.
    
    Additionally, in a case where we attempt a ping but it fails for some reason,
    but we're also unable to bind the port to listen ourselves, we give the
    user a more informative error message about the potential cause of that
    problem, and offer two possible solutions: figure out what other process
    is already binding the port, or file a bug if that process happens to be
    JabRef (since that would indicate that a 1s timeout isn't sufficient).
    jakkarth committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    6eff484 View commit details
    Browse the repository at this point in the history