Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine BackupManager #9054

Merged
merged 29 commits into from
Aug 15, 2022
Merged

Refine BackupManager #9054

merged 29 commits into from
Aug 15, 2022

Commits on Aug 13, 2022

  1. Refine BackupManager 

    Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
    @koppor @Siedlerchr @calixtus
    3 people committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    8051bfd View commit details
    Browse the repository at this point in the history

  2. Fix BackupManager 

    Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
    @koppor @calixtus
    koppor and calixtus committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    83938bf View commit details
    Browse the repository at this point in the history

  3. Exchange "bak" and "sav" 

    Co-authored-by: Christoph <siedlerkiller@gmail.com>
    @koppor @Siedlerchr
    koppor and Siedlerchr committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    b607fff View commit details
    Browse the repository at this point in the history

  4. Refine backup message to show backup path 

    Co-authored-by: Christoph <siedlerkiller@gmail.com>
    @koppor @Siedlerchr
    koppor and Siedlerchr committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    266f997 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2022

  1. Merge remote-tracking branch 'origin/main' into ten-saves-for-backup-… 

    …manager

# Conflicts:
#	CHANGELOG.md
    @koppor
    koppor committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    dc5710a View commit details
    Browse the repository at this point in the history

  2. Introduce BackupFileUtil

    @koppor
    koppor committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    78065e2 View commit details
    Browse the repository at this point in the history

  3. Use AtomicFileWriter

    @koppor
    koppor committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    3592ad4 View commit details
    Browse the repository at this point in the history

  4. Update src/main/java/org/jabref/logic/util/io/BackupFileUtil.java 

    Co-authored-by: Christoph <siedlerkiller@gmail.com>
    @koppor @Siedlerchr
    koppor and Siedlerchr committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    7c6fd38 View commit details
    Browse the repository at this point in the history

  5. More comments

    @koppor
    koppor committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    e7660e3 View commit details
    Browse the repository at this point in the history

  6. Align JabRefGUI#openLastEditedDatabases() with OpenDatabaseAction#loa… 

    …dDatabase(Path)
    @koppor
    koppor committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    b2da978 View commit details
    Browse the repository at this point in the history

  7. Remove unused parameter "raisePanel"

    @koppor
    koppor committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    d26e218 View commit details
    Browse the repository at this point in the history

  8. WIP: Fix opening of databases i) on startup, ii) using File > Open 

    - i: Reuse OpenDataBaseAction (instead of code duplication)
- ii: Remove double initialization of BackupManager
    @koppor
    koppor committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    d8b48dd View commit details
    Browse the repository at this point in the history

  9. Experiment with needsBackup

    @koppor
    koppor committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    9c5cac5 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2022

  1. Fix variable name

    @koppor
    koppor committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    457c4a5 View commit details
    Browse the repository at this point in the history

  2. Remove obsolete method

    @koppor
    koppor committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    3f1ffc6 View commit details
    Browse the repository at this point in the history

  3. Remove duplicate code

    @koppor
    koppor committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    e171c04 View commit details
    Browse the repository at this point in the history

  4. Switch from DelayTaskThrottler to Java's ScheduledThreadPoolExecutor

    @koppor
    koppor committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    b580577 View commit details
    Browse the repository at this point in the history

  5. Group together code cloned methods

    @koppor
    koppor committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    7aa1b76 View commit details
    Browse the repository at this point in the history

  6. Enable "needsBackup" strategy

    @koppor
    koppor committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    7f04fa3 View commit details
    Browse the repository at this point in the history

  7. Ensure that backup is a recent one

    @koppor
    koppor committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    bf18715 View commit details
    Browse the repository at this point in the history

  8. Fix checkstyle

    @koppor
    koppor committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    dacd300 View commit details
    Browse the repository at this point in the history

  9. Removed JabRefGUI import

    @calixtus
    calixtus committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    2f8a75e View commit details
    Browse the repository at this point in the history

  10. Introdce OS.APP_DIR_APP_* 

    Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
Co-authored-by: ThiloteE <73715071+ThiloteE@users.noreply.github.com>
Co-authored-by: Houssem Nasri <housi.housi2015@gmail.com>
Co-authored-by: Benedikt Tutzer <btut@users.noreply.github.com>
    @koppor @Siedlerchr
    @calixtus @ThiloteE @HoussemNasri @btut
    6 people committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    2db1fab View commit details
    Browse the repository at this point in the history

  11. Fix checkstyle

    @koppor
    koppor committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    1c45014 View commit details
    Browse the repository at this point in the history

  12. Merge remote-tracking branch 'origin/main' into ten-saves-for-backup-… 

    …manager
    @koppor
    koppor committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    e722e3d View commit details
    Browse the repository at this point in the history

  13. Try to fix tests

    @koppor
    koppor committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    c317aea View commit details
    Browse the repository at this point in the history

  14. Remove check for concrete hash code

    @koppor
    koppor committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    122a236 View commit details
    Browse the repository at this point in the history

  15. Fix checkstyle

    @koppor
    koppor committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    1e2c2fa View commit details
    Browse the repository at this point in the history

  16. Refine comment on expected behavior

    @koppor
    koppor committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    80797de View commit details
    Browse the repository at this point in the history