Observable Preferences L (GrobidPreferences) #9065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calixtus
added
status: ready-for-review
Comment on lines
+776
to
+778
| } catch (IOException ignored) { | ||
| // Ignored | ||
| } |
There was a problem hiding this comment.
I wouldn't ignore this, because if it fails then preferences may have been corrupted.
There was a problem hiding this comment.
I just copied it from getStringList. Also Exception occurs only, if the stringreader is fails to read a line in the prefs. Worst case is that a preference option is not loaded correctly and has to be reconfigured manually.
| int i = 0; | ||
| List<String> series = new ArrayList<>(); | ||
| String item; | ||
| while (!StringUtil.isBlank(item = get(key + i))) { |
There was a problem hiding this comment.
isNotBlank is basically a method to be used as a reference in .map(StringUtil::isNotBlank) like Objects::isNull
There was a problem hiding this comment.
But still adding a literal 'not' reads better than '!'
Siedlerchr
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #8422 to keep the big refactor going.
Stopping here to keep it reviewable
.
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)