Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button in preference dialog to reset preferences #915

Merged
merged 1 commit into from
Mar 7, 2016

Conversation

tobiasdiez
Copy link
Member

Implements #455 and/or koppor#47.

  • Change in CHANGELOG.md described?
  • Changes in pull request outlined? (What, why, ...)
  • Tests created for changes? - only UI change
  • Tests green?

@tobiasdiez tobiasdiez added type: enhancement status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Mar 6, 2016
@simonharrer
Copy link
Contributor

Nice. Looks good. But I would add a note that resetting the perferences requires a restart (see change the language or the remote settings).

@tobiasdiez
Copy link
Member Author

Good point. An info message is now shown.

@simonharrer
Copy link
Contributor

Looks good to me.

oscargus added a commit that referenced this pull request Mar 7, 2016
Add button in preference dialog to reset preferences
@oscargus oscargus merged commit 904111c into JabRef:master Mar 7, 2016
@tobiasdiez tobiasdiez deleted the resetPreferences branch March 8, 2016 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants