Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing CSS for some dialogs #9150

Merged
merged 6 commits into from
Sep 12, 2022
Merged

Fix missing CSS for some dialogs #9150

merged 6 commits into from
Sep 12, 2022

Conversation

HoussemNasri
Copy link
Member

@HoussemNasri HoussemNasri commented Sep 11, 2022

Follow up to #8939

The dialogs are:

  • GlobalSearchResultDialog
  • MultiMergeEntriesView

The reason behind the missing CSS is that these dialogs don't have the main window as an owner. The owner is responsible for passing the CSS stylesheets downstream, and if the owner is not set for the dialog, the CSS must be loaded explicitly. Fortunately, dialogs shown with DialogService have their owner set automatically, allowing CSS to load successfully.

Before

gzeghhh

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@HoussemNasri HoussemNasri added ui status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Sep 11, 2022
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice thanks for fixing!

@Siedlerchr Siedlerchr merged commit 9604f7d into JabRef:main Sep 12, 2022
Siedlerchr added a commit to LIM0000/jabref that referenced this pull request Sep 12, 2022
* upstream/main:
  Fix missing CSS for some dialogs (JabRef#9150)
  Bump org.eclipse.jgit from 6.2.0.202206071550-r to 6.3.0.202209071007-r (JabRef#9152)
  Bump mockito-core from 4.7.0 to 4.8.0 (JabRef#9151)
  [GSOC22] - D - Test the Three Way Merge UI (JabRef#9069)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants