Add double click on preview style to add/remove from the selected list #9498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authored-by: Dylan Goffinet <goffindy@gmail.com> See: [Double-click on preview style should add it to "Selected"](JabRef#9490)
Siedlerchr
reviewed
Dec 25, 2022
| @@ -275,4 +277,18 @@ public void sortDownButtonAction() { | |||
| public void resetDefaultButtonAction() { | |||
| viewModel.resetDefaultLayout(); | |||
| } | |||
|
|
|||
| public void mouseClickedAvailable(MouseEvent event) { | |||
There was a problem hiding this comment.
Both methods can be made private, but apart from hat lgtm
Siedlerchr
previously approved these changes
Dec 25, 2022
Siedlerchr
added
the
status: ready-for-review
|
Thanks for your contribution! Just a minor change but otherwise lgtm |
Siedlerchr
added a commit
that referenced
this pull request
Dec 26, 2022
* upstream/main: Bump classgraph from 4.8.152 to 4.8.153 (#9502) Bump slf4j-api from 2.0.5 to 2.0.6 (#9501) Bump org.beryx.jlink from 2.25.0 to 2.26.0 (#9500) Bump lucene-queries from 9.4.1 to 9.4.2 (#9499) Add double click on preview style to add/remove from the selected list (#9498) Fix no context menu with sorting on all entries group (#9497) Observable Preferences S (LastExportPath and Cleanups in JabRefPreferences and Globals) (#9493)
Siedlerchr
added a commit
that referenced
this pull request
Dec 27, 2022
* upstream/main: Bump classgraph from 4.8.152 to 4.8.153 (#9502) Bump slf4j-api from 2.0.5 to 2.0.6 (#9501) Bump org.beryx.jlink from 2.25.0 to 2.26.0 (#9500) Bump lucene-queries from 9.4.1 to 9.4.2 (#9499) Add double click on preview style to add/remove from the selected list (#9498) Fix no context menu with sorting on all entries group (#9497)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9490
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)