Remove overquoting in jabrefHost on Linux #9590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
approved these changes
Jan 31, 2023
Siedlerchr
added
the
status: ready-for-review
|
Tests fail, but not because of your changes, so should be good. The abbreviation list tests are unstable. |
calixtus
approved these changes
Feb 1, 2023
Siedlerchr
added a commit
that referenced
this pull request
Feb 3, 2023
…ialog * upstream/main: Remove overquoting in jabrefHost on Linux (#9590) Squashed 'buildres/csl/csl-locales/' changes from 3961332022..9b9366b71b Squashed 'buildres/csl/csl-styles/' changes from 50eea55b2c..b111f31efe Checkstyle correction checkstyle issue removal removed unwanted resources related to BibTeXml Bump tinylog-impl from 2.5.0 to 2.6.0 Bump slf4j-tinylog from 2.5.0 to 2.6.0 Exporter Bibtex Xml removed Importer Format changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove overquoting in jabrefHost.py, fixing #9588. On Linux (not MacOS), the script wraps the BibTeX passed to JabRef via CLI parameter in an extra set of ' quotes. Since the data is never evaluated by a shell script, the quotes are passed to JabRef and are stored in the database. This may be the cause for the garbage charactes observed in #9582; however, this fix does not address that issue.
Fixes #9588
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)