Preserve bibtex import order #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasdiez
added
cleanup-ops
testing
status: ready-for-review
Merged
| @@ -223,7 +219,7 @@ public void actionPerformed(ActionEvent e) { | |||
| Globals.prefs.put(JabRefPreferences.EXPORT_WORKING_DIRECTORY, file.getParent()); | |||
|
|
|||
| final File finFile = file; | |||
| final Set<String> finEntryIDs = entryIds; | |||
| final List<BibEntry> finEntries = entries; | |||
There was a problem hiding this comment.
Why is a new variable introduced?
There was a problem hiding this comment.
Further down it is used in an anonymous method, which is only possible if it final.
|
👍 (Just one question and one space...) I guess an intermediate step would be to have a List of ids instead of a Set as that list should probably have a smaller memory footprint compared to bibentry, but as long as it is not a problem (and I guess it isn't, even with thousands of entries), this seems to be the way to go! |
|
👍 |
tobiasdiez
added a commit
that referenced
this pull request
Mar 17, 2016
Preserve bibtex import order
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@obraliar #504 (comment) noted that the order of the bibentries in
parserResult.getDatabase().getEntriesis not the same as in the bib file.As it turned out, fixing the order required to store the bibentries not as
Map<id, BibEntry>but simply as a list. So I removed almost everything which is connected to ID's. Now they are only used for writing bibentries (to determine the original order) and for the sql export.