Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganized "General tab" (preamble still here) and "String constants… #9836

Merged
merged 8 commits into from
May 6, 2023

Conversation

deybis17
Copy link
Contributor

@deybis17 deybis17 commented May 3, 2023

…" placed after "Citation key patterns"

Fixes #9818

  • Reorganization of the Order of Tabs:
    Before: General, Saving, String constants, Citation key patterns and Content selectors
    Now: General, Saving, Citation key patterns, String constants and Content selectors

  • Reorganization of the contents in General Tab:
    Before: General, Override default file directories and Preamble
    Now: Override default file directories, General and Preamble

  • It still missing to separate Preamble seccion in General tab and locate it in its own tab (Preamble Tab)

image

Compulsory checks

@Siedlerchr
Copy link
Member

Please also add a changelog entry

@koppor
Copy link
Member

koppor commented May 4, 2023

@deybis-villegas Thank you for working on this.

One more thing. Can you rename the 2nd general heading to "Miscellaneous". You will also need to add this string to JabRef_en.properties. see https://devdocs.jabref.org/code-howtos/localization.html

image

@deybis17 deybis17 marked this pull request as ready for review May 4, 2023 16:37
@koppor
Copy link
Member

koppor commented May 4, 2023

Can't do quick comment, because new screenshot is there. - I merged main so that this branch has no conflicts.

@deybis17
Copy link
Contributor Author

deybis17 commented May 4, 2023

General and preamble tab look like this now

image
image

Can't do quick comment, because new screenshot is there. - I merged main so that this branch has no conflicts.

@koppor koppor mentioned this pull request May 4, 2023
@koppor
Copy link
Member

koppor commented May 4, 2023

I am so sorry that I did not describe the picture content of the issue description as text.

May I mark the demand of the issue with an arrow and a yellow box?

image

As text: Swap "library mode" and "library encoding".

@deybis17
Copy link
Contributor Author

deybis17 commented May 4, 2023

I am so sorry that I did not describe the picture content of the issue description as text.

May I mark the demand of the issue with an arrow and a yellow box?

image

As text: Swap "library mode" and "library encoding".

Now it looks like this:

image

@calixtus
Copy link
Member

calixtus commented May 4, 2023

I took the liberty to shorten the changelog message a little bit. I hope you don't mind.

@Siedlerchr Siedlerchr merged commit 90be45a into JabRef:main May 6, 2023
@Siedlerchr
Copy link
Member

Thanks a lot for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rearrange content of Library Properties Dialog
5 participants