Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID based search for JSTOR #336

Closed
wants to merge 4 commits into from
Closed

ID based search for JSTOR #336

wants to merge 4 commits into from

Conversation

joethei
Copy link
Contributor

@joethei joethei commented Dec 1, 2020

implemented in JabRef/jabref#7145

@@ -60,6 +60,12 @@ The [International Association for Cryptologic Research](https://www.iacr.org/)

ID search is carried out using the Cryptology ePrint ID.

### JSTOR

Jstor is a digital library of academic content in many disciplines.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could take the same description of Jstor as in https://docs.jabref.org/collect/import-using-online-bibliographic-database

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, put the 2 sentences in different paragraphs, so as to reproduce the layout used for the other search engines.

### JSTOR

Jstor is a digital library of academic content in many disciplines.
ID search is carried out using either the [stable url](https://support.jstor.org/hc/en-us/articles/115004872507-Citation-Management-Permanently-Linking-to-Content-on-JSTOR) or a DOI.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, clarify what is the "stable url" compared to DOI: [Jstor stable url].

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stable url is basically the same as a doi.

Some stable urls only contain the doi(http://www.jstor.org/stable/10.1086/501484 for example)
while most use a common prefix(https://www.jstor.org/stable/90002164 = 10.2307/90002164)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this help section, that would be too much information. I suggest : "ID search is carried out using either the Jstor stable url or the DOI."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which is what if have written.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost 😉 : I recommended [stable jstor url]. Plus "the" or "a" for both.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, you are correct, fixed.

@joethei joethei requested a review from mlep December 14, 2020 18:52
Copy link
Contributor

@mlep mlep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your involvement in improving JabRef!

@koppor
Copy link
Member

koppor commented Jan 1, 2021

Need to postpone a merge, because we needed to disable JSTOR (at JabRef/jabref#7229), because JabRef gets blocked by JSTOR. We currently have no clue how to fix it.

@koppor koppor closed this Mar 29, 2021
@koppor koppor deleted the branch JabRef:master March 29, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants