-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug #13 #14
Open
w4lle
wants to merge
1
commit into
Jacksgong:master
Choose a base branch
from
w4lle:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix bug #13 #14
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,7 @@ | |
|
||
import android.annotation.TargetApi; | ||
import android.content.Context; | ||
import android.graphics.Rect; | ||
import android.os.Build; | ||
import android.util.AttributeSet; | ||
import android.util.Log; | ||
|
@@ -36,6 +37,8 @@ public class CustomRootLayout extends LinearLayout { | |
|
||
private final static String TAG = "JFrame.CustomRootLayout"; | ||
|
||
private int[] mInsets = new int[4]; | ||
|
||
public CustomRootLayout(Context context) { | ||
super(context); | ||
init(); | ||
|
@@ -231,4 +234,31 @@ public interface OnKeyboardShowingListener { | |
|
||
} | ||
|
||
|
||
public final int[] getInsets() { | ||
return mInsets; | ||
} | ||
|
||
/** | ||
* fix bug #13 | ||
*/ | ||
@Override | ||
protected final boolean fitSystemWindows(Rect insets) { | ||
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) { | ||
// Intentionally do not modify the bottom inset. For some reason, | ||
// if the bottom inset is modified, window resizing stops working. | ||
// TODO: Figure out why. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TODO的这个说明正是开源需要的,将下面为什么 上,左,右 置位0提供说明,与覆盖的case。 |
||
|
||
mInsets[0] = insets.left; | ||
mInsets[1] = insets.top; | ||
mInsets[2] = insets.right; | ||
|
||
insets.left = 0; | ||
insets.top = 0; | ||
insets.right = 0; | ||
} | ||
|
||
return super.fitSystemWindows(insets); | ||
} | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix #13 这个可以放到最后,在这个之前,用英文说明清晰这里覆写这个的作用。