Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subcomponents don't see bindings from parent in multibindings #208

Open
quiro91 opened this issue Sep 13, 2020 · 1 comment
Open

Subcomponents don't see bindings from parent in multibindings #208

quiro91 opened this issue Sep 13, 2020 · 1 comment

Comments

@quiro91
Copy link
Contributor

quiro91 commented Sep 13, 2020

Parent's bindings are not present in the child subcomponent when using multibindings. This is clear in the test ModuleWithSubcomponentsTest, currently excluded. In order to fix it, we could check for existing binding from the parent scope in the build() method of Scope.Builder. I can raise a PR if you are OK with this solution

@JakeWharton
Copy link
Owner

Yeah I believe this is causing

// TODO reflect bug! Subcomponent multibindings propagation does not work.
excludeTest 'dagger.functional.subcomponent.SubcomponentMultibindingsTest', null
and maybe even some of the failures above that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants