Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #178 and bump version to 2.1.1 #179

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ozziefallick
Copy link

No description provided.

Removed utf-8 encoding step as recommended in JakeWharton#97 (comment). This is backwards-compatible with Python 2.
Fixed color encoding problem causing Issue JakeWharton#178
Version increases to 2.1.1 to cover fixes for Issues JakeWharton#147 and JakeWharton#178.
@barnhill
Copy link

barnhill commented Mar 24, 2022

(Forgive my ignorance with python) Does this change require usage of python3? If so why not update to python3 in pidcat.py? At least on the latest version of MacOS 12.3 pidcat will not run due to the removal of python2. The file pidcat.py had to be modified along with this change to point to #!/usr/bin/env -S python3 -u.

But now noticing that the package filtering doesnt work either when using python3

@oscarnylander
Copy link

(Forgive my ignorance with python) Does this change require usage of python3? If so why not update to python3 in pidcat.py? At least on the latest version of MacOS 12.3 pidcat will not run due to the removal of python2. The file pidcat.py had to be modified along with this change to point to #!/usr/bin/env -S python3 -u.

But now noticing that the package filtering doesnt work either when using python3

I tried this change on Python 2.7.18, and it seemed to work fine.

@barnhill
Copy link

I guess I could install python2 to the Mac again. Marcos 12.3 removed it by default.

@ozziefallick
Copy link
Author

ozziefallick commented Mar 26, 2022 via email

@barnhill
Copy link

With python3 the package filter was not working for me.

@liudengyong
Copy link

liudengyong commented Sep 30, 2022

With python3 the package filter was not working for me.

Maybe you should change first line like this:
#!/usr/bin/python3 -u

and the last line like this:
print(linebuf)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants