Skip to content
This repository has been archived by the owner on Apr 19, 2018. It is now read-only.

Downloaded android SDK doesn't contain proguard #57

Closed
danikula opened this issue Oct 30, 2014 · 6 comments
Closed

Downloaded android SDK doesn't contain proguard #57

danikula opened this issue Oct 30, 2014 · 6 comments

Comments

@danikula
Copy link

I don't specify path to android-sdk, so sdk-manager-plugin downloads sdk, tools, play services, support library and starts to build projects, but fails with message:

...
:app:proguardDebug FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:proguardDebug'.
> java.io.FileNotFoundException: C:\Users\danik\.android-sdk\tools\proguard\proguard-android.txt

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Downloaded by sdk-manager-plugin android-sdk doesn't contain proguard at path C:\Users\danik\.android-sdk\tools\

My build.gradle is

buildscript {
...
    dependencies {
        classpath 'com.jakewharton.sdkmanager:gradle-plugin:0.12.0'
...
    }
}

apply plugin: 'android-sdk-manager'
apply plugin: 'com.android.application'

android {
    compileSdkVersion 21
    buildToolsVersion '21.0.2'

    defaultConfig {
        minSdkVersion 14
        targetSdkVersion 18 
...
    }
    buildTypes {
        debug {
            signingConfig signingConfigs.debug
            runProguard true
            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
        }
        release {
            runProguard true
            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules-release.pro', 'proguard-rules.pro'
            signingConfig signingConfigs.release
        }
}
@meredrica
Copy link

yea, providing proguard configs would be nice. jenkins configuration effort would practically drop to zero if this was implemented

@meredrica
Copy link

Update: seems like this is missing in the android sdk package and has nothing to do with this plugin: https://code.google.com/p/android/issues/detail?id=72419

@JakeWharton
Copy link
Owner

New SDK is on master and will be in the next release.

@Egorand
Copy link

Egorand commented Apr 10, 2015

Hi @JakeWharton

When do you plan to release this fix?

Thanks

@niedzielski
Copy link

If there's a way I can help out with a release or snapshot release, please let me know!

wmfgerrit pushed a commit to wikimedia/integration-zuul-config that referenced this issue Sep 8, 2015
Replace apps-android-wikipedia-publish's UbuntuTrusty node label with
AndroidEmulator and add the android-emulator wrapper. The wrapper will
launch the emulator unnecessarily but will also install any missing SDK
dependencies. These changes can be reverted when the SDK Manager Gradle
plugin fix[0] is merged.

[0] JakeWharton/sdk-manager-plugin#57

Bug: T99115
Change-Id: I8395e2fad684a81d4274c1639995d64b4d8996a9
@debrechtabel
Copy link

@Egorand @niedzielski For a workaround until the next release, check out #73 (comment)

wmfgerrit pushed a commit to wikimedia/apps-android-wikipedia that referenced this issue Nov 20, 2015
There hasn't been a release of the SDK Manager Plugin for a while. The
latest release does not properly download ProGuard dependencies[0] which
requires us to use the Jenkins Android Emulator Plugin to download them
for CI. Since the Android Emulator CI server is very slow, a dependency
on it is impractical for jobs that otherwise would not need it. Use
JitPack to grab the SDK Manager Plugin's master HEAD, d0c113b.

[0] JakeWharton/sdk-manager-plugin#57

Change-Id: Ia0f5f8dc64a676bdead0bd79b36b8071d45cb516
hashar pushed a commit to wikimedia/integration-zuul-config that referenced this issue Nov 25, 2015
The SDK Manager Plugin previously did not properly download all
dependencies[0]. The latest version does, so the workaround of using the
Jenkins Android Emulator Plugin to download missing dependencies is no
longer needed. This should give us a nice performance boost for the
apps-android-wikipedia-publish job and reduce the load on jobs truly
dependent on the AndroidEmulator node.

[0] JakeWharton/sdk-manager-plugin#57

Change-Id: Idade13b6505eeb3f7154881e3e970db0f783e9ff
Depends-On: Ia0f5f8dc64a676bdead0bd79b36b8071d45cb516
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants