Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support kotlin static references #446

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

TimoPtr
Copy link

@TimoPtr TimoPtr commented Sep 29, 2021

In the new version of Timber it was not possible to use static references in Kotlin, like described in this issue #445.
To fix that, Forest is not a companion object of Timber anymore, and I added all the static functions to the Timber's companion object.

I added a dumb test, that only tests the usage of a static reference, but only with Throwable. I was not sure about the strategy to adopt, here do we add a small test for each static function or make a big one just to ensure that everything is invokable as a static reference in Kotlin. If needed I can test all the methods in order to ensure that future versions do not break this kind of usage.

I updated AGP but I can rollback if needed.

@TimoPtr
Copy link
Author

TimoPtr commented Jan 14, 2022

@JakeWharton is there any chance to merge this at some point?

@iiw
Copy link

iiw commented Apr 26, 2023

@TimoPtr I guess the project is abandoned

@JakeWharton
Copy link
Owner

The project is stable

@iiw
Copy link

iiw commented Apr 26, 2023

@JakeWharton why no PR's merged anymore?

@JakeWharton
Copy link
Owner

It's not a priority for me, and nothing is broken. Everything is a feature request.

@iiw
Copy link

iiw commented Apr 26, 2023

@JakeWharton got it. What is your policy to add new feature PR's to the project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants