Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BibLaTex multiprenote and multipostnote #4313

Closed
postylem opened this issue Jul 6, 2024 · 6 comments
Closed

Support BibLaTex multiprenote and multipostnote #4313

postylem opened this issue Jul 6, 2024 · 6 comments

Comments

@postylem
Copy link

postylem commented Jul 6, 2024

Please fill the following fields with a star (*) and provide as much related information as possible.

Pre-checks*

Please change the following [ ] to [x] for confirmation.

  • [ x] The feature request has not been suggested in this repository.

The Missed*

Is your feature request related to a problem? Please provide a clear and concise description of what the problem is.

  • BibLaTex 'multicite' commands (see biblatex docs, §3.9.3 Qualified Citation Lists) seem to be not (fully) supported. Specifically, there are no autocomplete snippets for a so-called multi-prenote and multi-postnote (notes which come before / after the whole list of citations).

    ✔️ While a multi-citation command \parencites, with the following syntax, is supported

    \parencites[pre][post]{bibid}[pre][post]{bibid} 

    ❌ the version with multiprenote and/or multipostnote (which are in parentheses) seem not to be supported:

    \parencites(multipre)(multipost)[pre][post]{bibid}[pre][post]{bibid} 

    This is the case with other multicite commands which all have the same syntax, such as \footcites, \textcites, \smartcites, and uppercase versions, etc. Since these are standard commands in biblatex, it seems reasonable they should be supported, but maybe this is intentional. Sorry if so.

The Solution*

Please provide a solution you would like to have.

  • Autocomplete snippets (and other support? see below) for these commands.

Anything Else?

Add any other context about the feature request below.

  • I am not sure whether this is part of LaTeX-Workshop's features or not, but the more egregious problem that I notice when using these commands is that they do not seem to be supported by the latex syntax highlighter, and that this issue arises even without the parenthetical arguments (and also the spellchecking I am using, but that is an issue for another extension).

    Screenshot 2024-07-06 at 14 06 31

    It's worth noting that the citation info on hover does work in all these cases.

@James-Yu
Copy link
Owner

James-Yu commented Jul 8, 2024

Thanks for the issue. Have you tried latex-workshop.intellisense.package.dirs and its documentation?

@jlelong
Copy link
Collaborator

jlelong commented Jul 8, 2024

I will look into the syntax highlighting issue jlelong/vscode-latex-basics#93

@jlelong
Copy link
Collaborator

jlelong commented Jul 8, 2024

As far as intellisense is concerned, the multi-prenote (or postnote) versions are included in biblabtex.cwl but these entries are ignored by our Python script, which generates the biblatex.json data file. I will look into the conversion toolchain

@postylem
Copy link
Author

postylem commented Jul 8, 2024

latex-workshop.intellisense.package.dirs

Thanks, I hadn't looked at that, but now that I did, and I'm not sure I understand. Are you referring to what jlelong mentioned re these versions with parens being generated into the biblatex.json data file?

@jlelong
Copy link
Collaborator

jlelong commented Jul 8, 2024

@James-Yu We used to have intellisense for macros containing (...), but it was apparently removed by d545d62. I cannot remember why, do you have a better memory than I do?

Edit : related to #4270

@James-Yu
Copy link
Owner

James-Yu commented Jul 9, 2024

Will check, may not be very soon sadly 😭

James-Yu added a commit to quoc-ho/LaTeX-Workshop that referenced this issue Aug 10, 2024
commit ff2ca23
Author: James Yu <yujianqiaojames@gmail.com>
Date:   Sun Aug 11 01:38:40 2024 +0800

    Fix James-Yu#4334 PDF viewer position retained across vscode reloads

commit be6da68
Author: Jerome Lelong <jerome.lelong@gmail.com>
Date:   Fri Aug 9 18:24:34 2024 +0200

    Add highlighting to the extension logs (James-Yu#4331)

    * Fix typo in log

    * Highlight extension's logs

    * Do not highlight the finale full stop

commit 693d709
Author: James Yu <yujianqiaojames@gmail.com>
Date:   Sat Aug 3 17:57:55 2024 +0800

    Fix linter errors

commit 82b7561
Author: James Yu <yujianqiaojames@gmail.com>
Date:   Sat Aug 3 17:56:37 2024 +0800

    Add tests to queue module of compile

commit 55e4c87
Author: James Yu <yujianqiaojames@gmail.com>
Date:   Wed Jul 31 18:49:38 2024 +0800

    Fix a find root in ws test as file glob order is not static

commit e9d6ec5
Author: Jerome Lelong <jerome.lelong@gmail.com>
Date:   Fri Jul 26 07:37:21 2024 +0200

    Update grammar files to jlelong/vscode-latex-basics@4795be4

commit bf2df7f
Author: James Yu <yujianqiaojames@gmail.com>
Date:   Mon Jul 22 00:56:18 2024 +0800

    Fix James-Yu#4313 Include (arg) macro signature in package intellisense

commit 53fdd38
Author: Jerome Lelong <jerome.lelong@gmail.com>
Date:   Mon Jul 8 15:52:47 2024 +0200

    Update grammar files to jlelong/vscode-latex-basics@1deac8f
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants