[WIP] Use Jest for Elasticsearch http #160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: JanusGraph#92 This adds http support to ElasticSearchIndex and removes support for the Transport and Client modes. It also refactors the add/delete scripts to use bindings since throwing a bunch of unique scripts at a Groovy compiler isn't the best idea. Signed-off-by: Keith Lohnes <krlohnes@us.ibm.com>
krlohnes
changed the title
krlohnes
force-pushed
the
92_es_http_only
branch
from
e85407c
to
bbd58a4
Compare
There are some small differences in the code required to test the different ES versions supported by JanusGraph. The code to support http in the ElasticSearchIndex, however, is the same. Therefore, I've only split up the test directories. If at some point in the future it's required to split up that file based off of version, we can do so then. Signed-off-by: Keith Lohnes <krlohnes@us.ibm.com>
krlohnes
force-pushed
the
92_es_http_only
branch
from
bbd58a4
to
6527a3e
Compare
|
@krlohnes I posted some questions on the mailing list regarding ES update work |
|
Closing this for now. It looks like ES support/compatibility is going well enough without it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #92
This adds http support to ElasticSearchIndex and removes support for the
Transport and Client modes. It also refactors the add/delete scripts to
use bindings since throwing a bunch of unique scripts at a Groovy
compiler isn't the best idea.