Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix DEP0066 deprecation #5

Closed
wants to merge 1 commit into from
Closed

fix DEP0066 deprecation #5

wants to merge 1 commit into from

Conversation

mathieu-aubin
Copy link

@mathieu-aubin
fix DEP0066 deprecation
263afff 
fixes [DEP0066: OutgoingMessage.prototype._headers, OutgoingMessage.prototype._headerNames](https://nodejs.org/api/deprecations.html#deprecations_dep0066_outgoingmessage_prototype_headers_outgoingmessage_prototype_headernames)

Hopefully
@jmealo
Copy link
Collaborator

jmealo commented Aug 26, 2019

@mathieu-aubin: Thank you for the PR. getHeaders() was added to OutgoingMessage in nodejs/node#10805. To support older versions of Node, we'll need to do something like this: this.getHeaders ? this.getHeaders() : this._headers (which hopefully should silence the runtime deprecation).

@jmealo jmealo self-assigned this Aug 26, 2019
@jmealo
Copy link
Collaborator

jmealo commented Sep 11, 2019

@mathieu-aubin: Since this code doesn't run and doesn't have tests I'm closing this. Thanks for reporting this issue. I'll credit you on the PR closing it.

@jmealo jmealo closed this Sep 11, 2019
@jmealo jmealo mentioned this pull request Sep 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jmealo jmealo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathieu-aubin @jmealo