Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C0 and C1 Control code support #241

Closed
OmegaRogue opened this issue May 10, 2020 · 13 comments
Closed

Add C0 and C1 Control code support #241

OmegaRogue opened this issue May 10, 2020 · 13 comments
Labels
unicode request Request for adding more symbols

Comments

@OmegaRogue
Copy link

it would be nice to have the control codes shown as their according control pictures instead of diamonds with question marks and boxes

@philippnurullin
Copy link
Member

Hi @OmegaRogue . Please add the screenshots. It's difficult to understand your request.

@trygveaa
Copy link

Control codes are generally not printable characters. When would they be shown?

Are you sure it's not your application rendering a control code as something else?

@alexeyten
Copy link
Contributor

@OmegaRogue
Copy link
Author

@OmegaRogue
Copy link
Author

this is what all non whitespace characters from ascii 0x00 to 0x1F look currently in JetBrains Mono:
image
this is the same file but opened in the IntelliJ BinEd Plugin, which has support for control pictures:
image
These still have the problem of being a bit too small to be easily read, so having these control pictures in JetBrains mono could make reading binary serialized data easier by having distinguishable symbols instead of boxes

@philippnurullin philippnurullin added the unicode request Request for adding more symbols label Jul 9, 2020
@somethingSTRANGE
Copy link

Characters associated with control code are probably best represented with symbols like those in the screenshot @OmegaRogue provided above, since it's easy to identify what they are.

N      S      S      E      E      E      A      B      B      H      L      V      F      C      S      S
 U      O      T      T      O      N      C      E      S      T      F      T      F      R      O      I
  L      H      X      X      T      Q      K      L
D      D      D      D      D      N      S      E      C      E      S      E      F      G      R      U      
 L      C      C      C      C      A      Y      T      A      M      U      S      S      S      S      S
  E      1      2      3      4      K      N      B      N             B      C

Personally, however, I have nostalgia for Code page 437 (used by the the original IBM PC) and how the control characters were represented there:

Codepage-437

The best roguelikes use code page 437.

That said, the @OmegaRogue suggestion makes more sense.

philippnurullin added a commit that referenced this issue Jul 14, 2021
- Added Control code support #241
- Update all # dependent glyphs #275
- Added Ɛ ↋ ↊ ૪ #356
- Changed the look of ~@ ligature #415
- Added EMQuad (u+2001) #439
- The tail of Italic “f” made shorter #441
- Reworked ⚠️ #450
- Added SemiBold weight #453
- Added more anchors to the marks #463
- Added replacement (u+FFFD) #461
- Added zeroWidthNoBreakSpace (u+FEFF) #467
- Fixed consistent of J in italic
@philippnurullin
Copy link
Member

Hi, added the Control codes. Experimented with placement of letters. The diagonal placement was not adding anything particular good. There were no additional space to make letters bigger, and there is a downside of shifting reading pattern from horizontal. Please see and test.
Grab the files from here https://github.com/JetBrains/JetBrainsMono/tree/master/fonts

@OmegaRogue
Copy link
Author

I don't see any characters for the control codes in those files, and whats weird is that I thought this issue was already resolved, as the control codes already got support in the IDEs (at least goland, where i tested it), and it works very well there, and i thought it was part of JetBrains Mono already, and that it just didnt work correctly in terminals

goland:
image
gedit:
image
fontforge:
image

@philippnurullin
Copy link
Member

Ok, let's see.
Here is a screenshot of what they should look.
Screenshot 2021-07-15 at 13 51 48
Can you please paste the actual unicode numbers for the symbols or a sampel of text so i can test it?

@OmegaRogue
Copy link
Author

OmegaRogue commented Jul 15, 2021

Uploading it as a gist caused problems with 0x00, so here's the file
C0.txt
in the format
0x[Unicode byte]: [character]

@OmegaRogue
Copy link
Author

OmegaRogue commented Jul 15, 2021

HT (0x09), LF (0x0A) and CR (0x0D) aren't in there, because they are tab, linefeed and carriage return, \t, \n and \r respectively

@OmegaRogue
Copy link
Author

the codes for the last half was missing a 1
C0.txt

philippnurullin added a commit that referenced this issue Jul 20, 2021
- Remapped Control codes unicode numbers #241
- Added ǒ ǐ ǔ ǖ ǘ ǚ ǜ #187
- Added even more anchors #463
@philippnurullin
Copy link
Member

Please test the latest push. Remapped the glyphs to the new unicode numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unicode request Request for adding more symbols
Projects
None yet
Development

No branches or pull requests

5 participants