[FIR] Copy attributes onto fake override accessors

This fixes a false positive NON_PUBLIC_CALL_FROM_PUBLIC_INLINE caused
by the published visibility attribute not being copied to a fake
override accessor.

#KT-70901 Fixed

analysis/low-level-api-fir/testData/lazyResolveScopes/intersectionOverrideWithImplicitTypeInsideAnonymousObject.after.txt

@@ -20,7 +20,7 @@ public open [ResolvedTo(BODY_RESOLVE)] fun foo([ResolvedTo(BODY_RESOLVE)] x: R|F
 
 public? open override [ResolvedTo(BODY_RESOLVE)] [IntersectionOverrideOriginalKey=second/B.bar, SubstitutedOverrideOriginalKey=second/B.bar] var bar: R|@R|second/Anno|(str = <strcat>(String(object ), R|second/constant|))  kotlin/String|
 
-    public? [ResolvedTo(BODY_RESOLVE)] [ContainingClassKey=<anonymous>] set([ResolvedTo(BODY_RESOLVE)] value: R|@R|second/Anno|(str = <strcat>(String(object ), R|second/constant|))  kotlin/String|): R|kotlin/Unit|
+    public? [ResolvedTo(BODY_RESOLVE)] [ContainingClassKey=<anonymous>, IntersectionOverrideOriginalKey=special/accessor] set([ResolvedTo(BODY_RESOLVE)] value: R|@R|second/Anno|(str = <strcat>(String(object ), R|second/constant|))  kotlin/String|): R|kotlin/Unit|
 
 public? open override [ResolvedTo(BODY_RESOLVE)] [IntersectionOverrideOriginalKey=second/B.bar, SubstitutedOverrideOriginalKey=second/C.bar] var bar: R|T|
 

analysis/low-level-api-fir/testData/lazyResolveScopes/intersectionOverrideWithImplicitTypeInsideAnonymousObject.before.txt

@@ -16,7 +16,7 @@ public open [ResolvedTo(STATUS)] fun foo([ResolvedTo(STATUS)] x: R|F| = LAZY_EXP
 
 public? open override [ResolvedTo(STATUS)] [DeferredCallableCopyReturnTypeKey=DeferredReturnTypeOfSubstitution(substitutor={T -> @R|second/Anno|(str = <strcat>(String(object ), R|second/constant|))  kotlin/String}, baseSymbol=FirIntersectionOverridePropertySymbol second/B.bar), IntersectionOverrideOriginalKey=second/B.bar, SubstitutedOverrideOriginalKey=second/B.bar] var bar: <implicit>
 
-    public? [ResolvedTo(STATUS)] [ContainingClassKey=<anonymous>] set([ResolvedTo(STATUS)] value: <implicit>): R|kotlin/Unit|
+    public? [ResolvedTo(STATUS)] [ContainingClassKey=<anonymous>, IntersectionOverrideOriginalKey=special/accessor] set([ResolvedTo(STATUS)] value: <implicit>): R|kotlin/Unit|
 
 public? open override [ResolvedTo(STATUS)] [DeferredCallableCopyReturnTypeKey=CallableCopyIntersection(mostSpecific=[FirPropertySymbol second/B.bar, FirPropertySymbol second/B.bar]), IntersectionOverrideOriginalKey=second/B.bar, SubstitutedOverrideOriginalKey=second/C.bar] var bar: <implicit>
 

analysis/low-level-api-fir/testData/lazyResolveScopes/intersectionOverrideWithImplicitTypeInsideAnonymousObjectScript.after.txt

@@ -20,7 +20,7 @@ public open [ResolvedTo(BODY_RESOLVE)] fun foo([ResolvedTo(BODY_RESOLVE)] x: R|F
 
 public? open override [ResolvedTo(BODY_RESOLVE)] [IntersectionOverrideOriginalKey=second/B.bar, SubstitutedOverrideOriginalKey=second/B.bar] var bar: R|@R|second/Anno|(str = <strcat>(String(object ), R|second/constant|))  kotlin/String|
 
-    public? [ResolvedTo(BODY_RESOLVE)] [ContainingClassKey=<anonymous>] set([ResolvedTo(BODY_RESOLVE)] value: R|@R|second/Anno|(str = <strcat>(String(object ), R|second/constant|))  kotlin/String|): R|kotlin/Unit|
+    public? [ResolvedTo(BODY_RESOLVE)] [ContainingClassKey=<anonymous>, IntersectionOverrideOriginalKey=special/accessor] set([ResolvedTo(BODY_RESOLVE)] value: R|@R|second/Anno|(str = <strcat>(String(object ), R|second/constant|))  kotlin/String|): R|kotlin/Unit|
 
 public? open override [ResolvedTo(BODY_RESOLVE)] [IntersectionOverrideOriginalKey=second/B.bar, SubstitutedOverrideOriginalKey=second/C.bar] var bar: R|T|
 

analysis/low-level-api-fir/testData/lazyResolveScopes/intersectionOverrideWithImplicitTypeInsideAnonymousObjectScript.before.txt

@@ -16,7 +16,7 @@ public open [ResolvedTo(STATUS)] fun foo([ResolvedTo(STATUS)] x: R|F| = LAZY_EXP
 
 public? open override [ResolvedTo(STATUS)] [DeferredCallableCopyReturnTypeKey=DeferredReturnTypeOfSubstitution(substitutor={T -> @R|second/Anno|(str = <strcat>(String(object ), R|second/constant|))  kotlin/String}, baseSymbol=FirIntersectionOverridePropertySymbol second/B.bar), IntersectionOverrideOriginalKey=second/B.bar, SubstitutedOverrideOriginalKey=second/B.bar] var bar: <implicit>
 
-    public? [ResolvedTo(STATUS)] [ContainingClassKey=<anonymous>] set([ResolvedTo(STATUS)] value: <implicit>): R|kotlin/Unit|
+    public? [ResolvedTo(STATUS)] [ContainingClassKey=<anonymous>, IntersectionOverrideOriginalKey=special/accessor] set([ResolvedTo(STATUS)] value: <implicit>): R|kotlin/Unit|
 
 public? open override [ResolvedTo(STATUS)] [DeferredCallableCopyReturnTypeKey=CallableCopyIntersection(mostSpecific=[FirPropertySymbol second/B.bar, FirPropertySymbol second/B.bar]), IntersectionOverrideOriginalKey=second/B.bar, SubstitutedOverrideOriginalKey=second/C.bar] var bar: <implicit>
 

compiler/fir/providers/src/org/jetbrains/kotlin/fir/scopes/impl/FirFakeOverrideGenerator.kt

@@ -502,6 +502,7 @@ object FirFakeOverrideGenerator {
             effectiveVisibility = effectiveVisibility,
             resolvePhase = origin.resolvePhaseForCopy,
             isOverride = true,
+            attributes = attributes.copy(),
         ).apply {
             replaceAnnotations(this@buildCopy.annotations)
         }
@@ -517,6 +518,7 @@ object FirFakeOverrideGenerator {
             resolvePhase = origin.resolvePhaseForCopy,
             parameterSource = valueParameters.first().source,
             isOverride = true,
+            attributes = attributes.copy(),
         ).apply {
             replaceAnnotations(this@buildCopy.annotations)
         }
@@ -530,6 +532,7 @@ object FirFakeOverrideGenerator {
             this.body = null
             resolvePhase = origin.resolvePhaseForCopy
             this.status = status.copy(visibility = newVisibility)
+            this.attributes = this@buildCopy.attributes.copy()
         }.also {
             if (it.isSetter) {
                 val originalParameter = it.valueParameters.first()

compiler/fir/tree/src/org/jetbrains/kotlin/fir/declarations/impl/FirDefaultPropertyAccessor.kt

@@ -42,12 +42,13 @@ abstract class FirDefaultPropertyAccessor(
     isOverride: Boolean,
     symbol: FirPropertyAccessorSymbol,
     resolvePhase: FirResolvePhase,
+    attributes: FirDeclarationAttributes,
 ) : FirPropertyAccessorImpl(
     source,
     resolvePhase,
     moduleData,
     origin,
-    FirDeclarationAttributes(),
+    attributes,
     status = when (effectiveVisibility) {
         null -> FirDeclarationStatusImpl(visibility, modality)
         else -> FirResolvedDeclarationStatusImpl(visibility, modality, effectiveVisibility)
@@ -114,6 +115,7 @@ class FirDefaultPropertyGetter(
     isOverride: Boolean = false,
     symbol: FirPropertyAccessorSymbol = FirPropertyAccessorSymbol(),
     resolvePhase: FirResolvePhase = FirResolvePhase.RAW_FIR,
+    attributes: FirDeclarationAttributes = FirDeclarationAttributes()
 ) : FirDefaultPropertyAccessor(
     source,
     moduleData,
@@ -129,6 +131,7 @@ class FirDefaultPropertyGetter(
     isOverride = isOverride,
     symbol = symbol,
     resolvePhase = resolvePhase,
+    attributes = attributes,
 )
 
 /**
@@ -150,6 +153,7 @@ class FirDefaultPropertySetter(
     parameterSource: KtSourceElement? = null,
     parameterAnnotations: List<FirAnnotation> = emptyList(),
     resolvePhase: FirResolvePhase = FirResolvePhase.RAW_FIR,
+    attributes: FirDeclarationAttributes = FirDeclarationAttributes()
 ) : FirDefaultPropertyAccessor(
     source,
     moduleData,
@@ -176,4 +180,5 @@ class FirDefaultPropertySetter(
     isOverride = isOverride,
     symbol = propertyAccessorSymbol,
     resolvePhase = resolvePhase,
+    attributes = attributes,
 )

compiler/testData/diagnostics/tests/inline/publishedApiSubstitutionOverride.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 @PublishedApi
 internal interface History<T> {
     var isIgnoringPlatformChanges: Boolean