Allow traits to be filtered by Added/Changed #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoJoJet
reviewed
Dec 9, 2022
| pub struct ChangeDetectionFetch<'w, Trait: ?Sized + TraitQuery> { | ||
| registry: &'w TraitImplRegistry<Trait>, | ||
| table_ticks: Vec<ThinSlicePtr<'w, UnsafeCell<ComponentTicks>>>, | ||
| sparse_components: Vec<&'w ComponentSparseSet>, |
There was a problem hiding this comment.
I don't like allocating here. Pending benchmarks, its probably faster to just iterate over the registered components and look them up in fetch, rather than caching it on the heap. The All iterators work this way.
There was a problem hiding this comment.
@JoJoJet sounds good!
Co-authored-by: JoJoJet <21144246+JoJoJet@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
Added/Changedfunctionality for bevy-trait-query!Closes: #23
What is needed to for this to go out of draft status:
add change detection tests
update documentation to show how change detection should be used