Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Code CI to handle hidden files #19

Closed
John-Robbins opened this issue Sep 3, 2024 · 0 comments · Fixed by #20
Closed

Fix Code CI to handle hidden files #19

John-Robbins opened this issue Sep 3, 2024 · 0 comments · Fixed by #20
Assignees
@John-Robbins
Labels
bug Something isn't working

Comments

@John-Robbins
Copy link
Owner

John-Robbins commented Sep 3, 2024 •
edited
Loading

You have to love surprise updates that break everything: https://github.blog/changelog/2024-08-19-notice-of-upcoming-deprecations-and-breaking-changes-in-github-actions-runners/

actions/upload-artifact#602
@John-Robbins John-Robbins added the bug Something isn't working label Sep 3, 2024
@John-Robbins John-Robbins self-assigned this Sep 3, 2024
John-Robbins added a commit that referenced this issue Sep 3, 2024
@John-Robbins
Upload action breaking change and skipping docs directory
4e6b361 
- Added fix for actions/upload-artifact@v4 breaking change of not uploading hidden files. Closes #19.
- Added skipping docs directory for pushes and PRs. Closes #15.
@John-Robbins John-Robbins mentioned this issue Sep 3, 2024
Merged
@John-Robbins John-Robbins linked a pull request Sep 3, 2024 that will close this issue
Upload action breaking change and skipping docs directory #20
Merged
John-Robbins added a commit that referenced this issue Sep 3, 2024
@John-Robbins
Merge pull request #20 from John-Robbins/semver-hah
d36dad7 
Upload action breaking change and skipping docs directory

- Added fix for actions/upload-artifact@v4 breaking change of not uploading hidden files. Closes #19.
- Added skipping docs directory for pushes and PRs. Closes #15.
- Also used a formatter extension in VS Code for YAML files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@John-Robbins John-Robbins

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upload action breaking change and skipping docs directory John-Robbins/tbp
1 participant
@John-Robbins