-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VSCode LSP plugin crashes for no apparent reason after the 1.30.0 release. #657
Comments
Do you have any repro steps for this crash? Also can you set |
No, not really. All I did was update the extension and suddenly it started almost immediately crashing whenever I opened an instance of VSCode. I've tried everything I could think of but the problem persists. Here are the logs with I've checked, and the problem also persists on new projects. |
Sorry about that, I will try to resolve this when I have some time. Please downgrade to the previous version in the meantime |
I'm unable to repro this crash so far. Could you try disabling sourcemap support and trying again to see if it crashes? Please also send the logs |
Hiya, I'm having a similar-looking problem. Tried disabling sourcemaps and still got this: If I downgrade it works fine with sourcemaps enabled. Good luck fixing :) |
I found the bug related to sourcemaps which should be fixed in 1dfbc66 I've generated a new nightly release at https://github.com/JohnnyMorganz/luau-lsp/actions/runs/9651994809 which should build in ~20 mins. Please try installing the generated .vsix and seeing if you still experience crashes. |
@alastairbarron if you still experience crashes, could you set |
Hiya :) I installed from the nightly release and appear to still be getting the same problem. Here are the verbose logs: Thanks! |
Sorry for the late response. I installed the nightly build and made a whole new rojo project, now I'm getting different results depending on what I set for sourcemaps. All of the below are with Here's what I get with sourcemaps enabled: And here's what I get with sourcemaps disabled: Yes, I get two separate logs when I set sourcemaps to disabled, which is also what happens if I don't have a rojo project at all and try to edit a .lua/.luau file. |
Downgrading to |
I have tested the latest nightly Verbose Log with Sourcemaps Enabled Verbose Log with Sourcemaps Disabled Messages Log with Sourcemaps Enabled Messages Log with Sourcemaps Disabled |
Appreciate you trying it out! These logs are somewhat surprising, i am very much confused on what could be tripping it up |
Ok, the only thing that I can think of left. Please can you try the new nightly release: https://github.com/JohnnyMorganz/luau-lsp/actions/runs/9702934716 |
Hello, how exactly are you supposed to install extensions through the .vsix? When using the plugin through the Install from VSIX option in extensions still getting this log |
Hey, I'm getting the same issue. I'm using the nightly release (https://github.com/JohnnyMorganz/luau-lsp/actions/runs/9702934716). Here are the logs, with verbose tracing. |
Hey folks, still unable to track down the issue unfortunately. I have another nightly release with some more trace debugging lines: https://github.com/JohnnyMorganz/luau-lsp/actions/runs/9730580051 This printf debugging isn't really working though, and I can't reproduce the crashes myself. I've started to ship debug symbols in the nightly release, so if anyone would be interested in trying to attach a debugger to find the crash stack trace, it would be immensely helpful |
I fixed my issue by installing vc_redist x64. Seems like it was just a user problem and not a problem with luau-lsp. |
Well, this is interesting. Although I had already installed it previously, it seems like "repairing" it fixed the problem. It wasn't an issue with luau-lsp for sure, but I also wonder why this caused the issue. Anyway, if anyone else is encountering the same problem, installing/repairing vc_redist is the fix. |
This also fixed the crash for me on Windows 11. I'm curious how you discovered this fix. |
Wow great find, this is looking like the problem. I've been struggling on this for so long. Thank you! I think i might know the cause of why we started depending on the vc redistributable. Maybe I can get rid of that dependency |
Perhaps you could make the program check for dependency if that is possible, and when it is found to be missing, the extension could ask the user whether they would like to have the extension download the dependency for them. |
This should be resolved in new release v1.31.0. https://github.com/JohnnyMorganz/luau-lsp/releases/tag/1.31.0 If you still experience issues, let me know! |
Hello, this is still crashing. |
This should be fixed for real in the next release. Thanks! |
The text was updated successfully, but these errors were encountered: