Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support-winarm64 #753

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

howmanysmall
Copy link
Contributor

This should just add windows arm64 support.

howmanysmall and others added 11 commits August 24, 2024 16:15
…um bum bum bum bum bum bum bum bum bum bum bum bum bum bum bum bum bum bum bum bum bum bum bum bum bum bum bum bum bum bum bum bum bum bum bum
Copy link
Contributor Author

@howmanysmall howmanysmall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore the horrendous commits, I was just testing to see if I could build it locally first.

@howmanysmall
Copy link
Contributor Author

I also don't know if I got it building for arm64, if you could check that, that would be sweet.

@JohnnyMorganz
Copy link
Owner

JohnnyMorganz commented Sep 11, 2024

Apologies for the delay!

This change isn't really any different than #682

It is still running on a windows-latest runner, which is x86_64 not arm, hence it will not build for ARM

@howmanysmall
Copy link
Contributor Author

Unfortunate. Any way to get the extension building for ARM64 at all, since that would be fine even if it's emulated.

@JohnnyMorganz
Copy link
Owner

Do windows ARM pcs support emulation of x86_64 binaries by default? I'm unfamiliar with this space

If so, then happy to add arm as an extra code target for the x86_64 version

@howmanysmall
Copy link
Contributor Author

yeah it's prism emulation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants