Upgrade to babel 7 and resolve source map support failure in tests #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elenadimitrova
force-pushed
the
maintenance/317-test-refactoring
branch
from
79d9a2a
to
7f3216d
Compare
elenadimitrova
changed the title
area
force-pushed
the
maintenance/317-test-refactoring
branch
from
ed3ef57
to
8248a22
Compare
area
approved these changes
Jan 25, 2019
area
reviewed
Jan 25, 2019
test-gas-costs/gasCosts.js
Outdated
| minerAddress: STAKER1, | ||
| realProviderPort: REAL_PROVIDER_PORT, | ||
| useJsTree: true | ||
| }); | ||
| const badClient = new MaliciousReputationMinerExtraRep( | ||
| { loader: contractLoader, minerAddress: STAKER2, realProviderPort: REAL_PROVIDER_PORT }, |
There was a problem hiding this comment.
Shouldn't the bad client get to use it too? 😄
There was a problem hiding this comment.
Yes of course.. I'll do that
elenadimitrova
force-pushed
the
maintenance/317-test-refactoring
branch
from
fefc28f
to
74c5c6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to coerce
mochato report back correct code line numbers on test failures (sample failing build reporting bad lines) we upgrad tobabel@7here. Although this hasn't solved the "line number" issue it is worth upgrading as it's not a straight forward change. Because.babelrcis no longer recognised as a global configuration, this had to be switched tobabel.config.jssee https://babeljs.io/docs/en/config-files#root-babelconfigjs-files and jestjs/jest#6053 (comment) for explanation.Ultimately after much digging in historical builds and merged changes, we managed to pinpoint the bad commit that started causing the incorrect line number reports in test failures. To solve this issue we pinned the
ganache-coreversion down to a working one. Logged trufflesuite/ganache#287 as a result.Upgrading to
node@10.12here as well to match the dApp.