Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix method ambiguity with in #186

Closed
ablaom opened this issue Jan 3, 2024 · 1 comment
Closed

Fix method ambiguity with in #186

ablaom opened this issue Jan 3, 2024 · 1 comment
Assignees
@ablaom

Comments

@ablaom
Copy link
Member

ablaom commented Jan 3, 2024

The issue was detected by Aqua.jl running on a client package: JuliaAI/MLJScikitLearnInterface.jl#64 (comment)

I believe, but am not absolutely sure, this overloading of in is not needed in the latest versions of MLJBase.jl. It was needed by now-deprecated learning network apparatus. However, as it is likely needed by older versions of MLJBase.jl, it cannot be removed until the next breaking release of MLJModelInterface.jl.
@ablaom ablaom self-assigned this Jan 3, 2024
@ablaom
Copy link
Member Author

ablaom commented Jan 17, 2024

Closed by #187

@ablaom ablaom closed this as completed Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ablaom ablaom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ablaom