Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Aqua.jl to tests #187

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Add Aqua.jl to tests #187

merged 2 commits into from
Jan 11, 2024

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Jan 4, 2024

... and address issues raised.

To be safe, we should:

  • Run MLJTestIntegration.jl

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (4393ab5) 89.26% compared to head (4ac5584) 88.53%.

Files Patch % Lines
src/model_traits.jl 83.33% 2 Missing ⚠️
src/equality.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #187      +/-   ##
==========================================
- Coverage   89.26%   88.53%   -0.74%     
==========================================
  Files           8        8              
  Lines         382      375       -7     
==========================================
- Hits          341      332       -9     
- Misses         41       43       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ablaom ablaom merged commit 6da0fa5 into dev Jan 11, 2024
3 of 4 checks passed
This was referenced Jan 11, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant