-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a groupby
method
#64
Conversation
Also a bump in package version is needed for the release. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
=======================================
Coverage 96.49% 96.49%
=======================================
Files 1 1
Lines 57 57
=======================================
Hits 55 55
Misses 2 2 ☔ View full report in Codecov by Sentry. |
Does it really make sense to have a docstring that says so little? Also, docstrings are exposed to users, so indications intended only at implementers would better go elsewhere. For join functions ( |
I am OK to turn this into a comment. |
Any objections to adding |
What packages use |
Really? julia> aggregate
WARNING: both Rasters and DataFrames export "aggregate"; uses of it
in module Main must be qualified
But in practice that amounts to the same thing for users of both packages. |
We will remove |
OK. @nalimilan - the state is that we export Would you be OK to remove:
before 2.0 release (it is technically breaking, but in practice I think it is not problematic to drop it. |
Sure. |
Released |
Add a
groupby
method to DataAPI so it can be shared accross packages like DataFrames.jl and DimensionalData.jl.See: rafaqz/DimensionalData.jl#591