Improve REPL SIGINT user experience. #17710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💯 Massive improvement. |
| @@ -74,6 +76,7 @@ function eval_user_input(ast::ANY, backend::REPLBackend) | |||
| iserr, lasterr = true, (err, catch_backtrace()) | |||
| end | |||
| end | |||
| ccall(:jl_sigatomic_end, Void, ()) | |||
There was a problem hiding this comment.
I don't see why this is needed --- isn't it dominated by a begin-end sequence?
There was a problem hiding this comment.
It isn't really needed in the sense that it should be unreachable. It is needed if we exit normally from the loop though so I included it for completeness (admittedly it won't help if one return from the loop).
It isn't dominated by a begin-end since the leave from the try-catch implicitly reset the defer_signal counter.
* Add a SIGINT dead time after a force throw
Fixes Jeff's issue in #17706
* Make the eval and print loop sigatomic to avoid sigint being delivered
outside `try`-`catch` blocks.
yuyichao
force-pushed
the
yyc/signals/dead-time
branch
from
ba15807
to
f0ba4ae
Compare
|
Can you summarize the behavioral upshot of this change? |
|
You get a prompt back after ^C instead of julia exiting. |
|
Brillant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a SIGINT dead time after a force throw
Fixes Jeff's issue in Unreliable SIGINT delivery #17706
Make the eval and print loop sigatomic to avoid sigint being delivered
outside
try-catchblocks.