[Release-0.6] Fix missing bounds checks for trailing zero dimensions #23723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbauman
added
backport pending 0.6
kind:bugfix
|
Awesome, thanks! Looks like at least AppVeyor is passing so far. Retargeting aa/backports-0.6 would be awesome, otherwise one of us will have to rebase once the other is merged. |
|
Test failures were all due to CI using the wrong dependencies/toolchain for 0.6. Retargeted to your branch, @ararslan. I'll let you merge it. |
|
Thanks so much, Matt! I really appreciate it. |
ararslan
pushed a commit
that referenced
this pull request
Sep 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #23629 for 0.6. It is done independently from the fix for master (in #23628) due to all the deprecation changes.
Cc @ararslan. This should presumably be re-targeted to your backports PR branch, but I wanted to make sure tests passed independently first.