replace RowVector(shape...) constructors/calls with RowVector(uninitialized, shape...) #24786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sacha0
added
domain:arrays
|
Absent objections or requests for time, I plan to merge these changes this evening PT or later. Best! |
…T}(uninitialized, shape...) etc.
|
Rebased. Planning to merge after rerunning CI. Best! |
fredrikekre
approved these changes
Nov 28, 2017
base/deprecated.jl
Outdated
| # deprecate RowVector{T}(shape...) constructors to RowVector{T}(uninitialized, shape...) equivalents | ||
| @deprecate RowVector{T}(n::Int) where {T} RowVector{T}(uninitialized, n) | ||
| @deprecate RowVector{T}(n1::Int, n2::Int) where {T} RowVector{T}(uninitialized, n1, n2) | ||
| @deprecate RowVector{T}(n::Tuple{Int}) where {T} RowVector{T}(uninitializd, n) |
There was a problem hiding this comment.
uninitializd -> uninitialized
I would have thought you were a master of spelling uninitialized after this series of PR's 😉
There was a problem hiding this comment.
I consistently make either of two mistakes: unintialized, or uninitializd. Seems I have trouble typing vowels? 😄
…alized, shape...) equivalents.
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request deprecates uninitialized-
RowVectorconstructors of the formRowVector{T}(shape...)in favor ofRowVector{T}(uninitialized, shape...)equivalents. For background, please see #24595. Best!Tangentially, these methods do not appear to see use anywhere. Should we simply deprecate these methods altogether?