Tune Stateful iterator #25792
Merged
Tune Stateful iterator #25792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This attempts to address some of the performance regressions observed with the Stateful iterator #25763. It gets most of the way there, but unfortunately still ends up allocating the `Stateful` iterator object rather than propagating through the fields. Getting the rest of the way there will require some compiler tweaks.
vtjnash
approved these changes
Jan 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to address some of the performance regressions observed
with the Stateful iterator #25736. It gets most of the way there,
but unfortunately still ends up allocating the
Statefuliteratorobject rather than propagating through the fields. Getting the rest
of the way there will require some compiler tweaks.