in Channel put!, convert value to Channel type
#29092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
approved these changes
Sep 10, 2018
base/channels.jl
Outdated
| check_channel_state(c) | ||
| isbuffered(c) ? put_buffered(c,v) : put_unbuffered(c,v) | ||
| vT = convert(T, v) |
There was a problem hiding this comment.
It's no longer a performance issue to reuse the name v for this. Style is a different question, but I thought I'd mention it.
There was a problem hiding this comment.
Thanks. I was partly skeptical when I did this. Will add a commit to reuse name.
`put!(ch::Channel{T}, v)` should convert `v` to type `T`.
This can prevent errors like:
```
julia> c = Channel{Int}(0)
Channel{Int64}(sz_max:0,sz_curr:0)
julia> @async put!(c, :a)
Task (runnable) @0x00007ff5b9d79270
julia> isready(c) && take!(c)
ERROR: TypeError: in take_unbuffered, in typeassert, expected Int64, got Symbol
Stacktrace:
[1] take_unbuffered(::Channel{Int64}) at ./channels.jl:323
[2] take!(::Channel{Int64}) at ./channels.jl:306
[3] top-level scope at none:0
```
tanmaykm
force-pushed
the
tan/chantype
branch
from
4fc7f69
to
63e84da
Compare
|
added tests |
JeffBezanson
added
kind:bugfix
|
I think this is a bugfix, but will see what triage thinks about backporting. |
|
I'd be curious to hear what @DatName's objection to this is. |
|
@StefanKarpinski I think, that if you are explicitly creating a channel for Int, you should not be putting some other stuff in there silently. It is easy to do a convertion explicitly on user's side, if needed, so no need for this "behind-the-curtains-magic", so to speak. |
|
I see your point of view. However, we do automatic conversion when values are put into typed contexts of all kinds already. Our conversions are quite strict about what conversions they will do without error: the value must be convertible exactly or an |
|
For values that aren't convertible (e.g. a string) this gives an error sooner than we did before. |
JeffBezanson
added
kind:minor change
mortenpi
added a commit
to mortenpi/julia
that referenced
this pull request
Dec 1, 2018
fredrikekre
pushed a commit
that referenced
this pull request
Dec 1, 2018
fredrikekre
pushed a commit
that referenced
this pull request
Dec 1, 2018
fredrikekre
pushed a commit
that referenced
this pull request
Dec 3, 2018
fredrikekre
pushed a commit
that referenced
this pull request
Dec 4, 2018
fredrikekre
pushed a commit
that referenced
this pull request
Dec 4, 2018
fredrikekre
added a commit
that referenced
this pull request
Dec 5, 2018
changes between Julia 1.0 and 1.1, including: - Custom .css-style for compat admonitions. - Information about compat annotations to CONTRIBUTING.md. - NEWS.md entry for PRs #30090, #30035, #30022, #29978, #29969, #29858, #29845, #29754, #29638, #29636, #29615, #29600, #29506, #29469, #29316, #29259, #29178, #29153, #29033, #28902, #28761, #28745, #28708, #28696, #29997, #28790, #29092, #29108, #29782 - Compat annotation for PRs #30090, #30013, #29978, #29890, #29858, #29827, #29754, #29679, #29636, #29623, #29600, #29440, #29316, #29259, #29178, #29157, #29153, #29033, #28902, #28878, #28761, #28708, #28156, #29733, #29670, #29997, #28790, #29092, #29108, #29782, #25278 - Documentation for broadcasting CartesianIndices (#30230). - Documentation for Base.julia_cmd(). - Documentation for colon constructor of CartesianIndices (#29440). - Documentation for ^(::Matrix, ::Number) and ^(::Number, ::Matrix). - Run NEWS-update.jl. Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com> Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
fredrikekre
added a commit
that referenced
this pull request
Dec 5, 2018
changes between Julia 1.0 and 1.1, including: - Custom .css-style for compat admonitions. - Information about compat annotations to CONTRIBUTING.md. - NEWS.md entry for PRs #30090, #30035, #30022, #29978, #29969, #29858, #29845, #29754, #29638, #29636, #29615, #29600, #29506, #29469, #29316, #29259, #29178, #29153, #29033, #28902, #28761, #28745, #28708, #28696, #29997, #28790, #29092, #29108, #29782 - Compat annotation for PRs #30090, #30013, #29978, #29890, #29858, #29827, #29754, #29679, #29636, #29623, #29600, #29440, #29316, #29259, #29178, #29157, #29153, #29033, #28902, #28878, #28761, #28708, #28156, #29733, #29670, #29997, #28790, #29092, #29108, #29782, #25278 - Documentation for broadcasting CartesianIndices (#30230). - Documentation for Base.julia_cmd(). - Documentation for colon constructor of CartesianIndices (#29440). - Documentation for ^(::Matrix, ::Number) and ^(::Number, ::Matrix). - Run NEWS-update.jl. Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com> Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
fredrikekre
added a commit
that referenced
this pull request
Dec 5, 2018
Addition of NEWS and compat admonitions for important changes between Julia 1.0 and 1.1, including: - Custom .css-style for compat admonitions. - Information about compat annotations to CONTRIBUTING.md. - NEWS.md entry for PRs #30090, #30035, #30022, #29978, #29969, #29858, #29845, #29754, #29638, #29636, #29615, #29600, #29506, #29469, #29316, #29259, #29178, #29153, #29033, #28902, #28761, #28745, #28708, #28696, #29997, #28790, #29092, #29108, #29782 - Compat annotation for PRs #30090, #30013, #29978, #29890, #29858, #29827, #29754, #29679, #29636, #29623, #29600, #29440, #29316, #29259, #29178, #29157, #29153, #29033, #28902, #28878, #28761, #28708, #28156, #29733, #29670, #29997, #28790, #29092, #29108, #29782, #25278 - Documentation for broadcasting CartesianIndices (#30230). - Documentation for Base.julia_cmd(). - Documentation for colon constructor of CartesianIndices (#29440). - Documentation for ^(::Matrix, ::Number) and ^(::Number, ::Matrix). - Run NEWS-update.jl. Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com> Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
put!(ch::Channel{T}, v)should convertvto typeT.This can prevent errors like: