add compat annotation for map!(f, values(dict)) (from #31223) #35184
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfourquet
added
the
domain:collections
|
Maybe add it to NEWS for that branch and HISTORY on master? |
fredrikekre
approved these changes
Mar 20, 2020
Sounds good, will do. |
rfourquet
force-pushed
the
rf/map-dict-values-compat
branch
from
5f556ef
to
763b0ce
Compare
If that's fine, I will push directly the change to that branch when this PR is merged, to avoid opening another PR (I'm not familiar how we work with release branches). |
KristofferC
pushed a commit
that referenced
this pull request
Mar 23, 2020
27 tasks
KristofferC
pushed a commit
that referenced
this pull request
Mar 23, 2020
oxinabox
pushed a commit
to oxinabox/julia
that referenced
this pull request
Apr 8, 2020
ravibitsgoa
pushed a commit
to ravibitsgoa/julia
that referenced
this pull request
Apr 9, 2020
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also didn't get a NEWS.md item, but this was for Julia 1.2... shall we add news now?