Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format extensions with parent in @time_imports report #47945

Merged
merged 3 commits into from
Dec 21, 2022

Conversation

IanButterworth
Copy link
Sponsor Member

Just adds the parent of the extension for context on an extension. See the last line here

julia> @time_imports using Colors, PGFPlotsX
      1.4 ms  Statistics
     41.5 ms  FixedPointNumbers
      0.7 ms  Reexport
     93.5 ms  ColorTypes
    144.6 ms  Colors
      0.7 ms  ArgCheck
      0.6 ms  DefaultApplication
      1.5 ms  DocStringExtensions
      9.6 ms  MacroTools
      0.7 ms  UnPack
      0.9 ms  Parameters
      0.5 ms  Requires
      0.8 ms  DataValueInterfaces
      1.7 ms  DataAPI
      0.7 ms  IteratorInterfaceExtensions
      0.7 ms  TableTraits
     15.6 ms  Tables
     80.2 ms  PGFPlotsX
      0.8 ms  PGFPlotsX → ColorsExt

@IanButterworth IanButterworth added the backport 1.9 Change should be backported to release-1.9 label Dec 21, 2022
@gitboy16
Copy link
Contributor

Hi, sorry I am not sure to understand what the last line mean? Would it be possible to update the documentation to explain it? Thank you.

@IanButterworth
Copy link
Sponsor Member Author

Would it be possible to update the documentation to explain it?

Updated. If you unfamiliar with package extensions check out https://docs.julialang.org/en/v1.10-dev/manual/code-loading/#%22Extension%22s

@gitboy16
Copy link
Contributor

Thank you. So it means that when module PGFPlotsX is loaded then module ColorsExt is automatically loaded as well. Maybe it is worth adding a comment or the link you provided under help ?@time_imports. Thanks again.

@IanButterworth
Copy link
Sponsor Member Author

I added a link to the appropriate place in the manual

@IanButterworth IanButterworth merged commit 6d4132b into JuliaLang:master Dec 21, 2022
@IanButterworth IanButterworth deleted the ib/time_imports_ext branch December 21, 2022 20:52
KristofferC pushed a commit that referenced this pull request Dec 28, 2022
@KristofferC KristofferC mentioned this pull request Dec 28, 2022
14 tasks
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Jan 2, 2023
@IanButterworth IanButterworth added the needs tests Unit tests are required for this change label Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs tests Unit tests are required for this change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants