Export num_stack_mappings to track the number of in-flight stack mappings and tasks in application #51301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adnan-alhomssi
changed the title
NHDaly
reviewed
Sep 13, 2023
NHDaly
reviewed
Sep 13, 2023
src/gc-stacks.c
Outdated
Comment on lines
76
to
79
| JL_DLLEXPORT uint32_t jl_get_num_stack_mappings() { | ||
| return jl_atomic_load_relaxed(&num_stack_mappings); | ||
| } |
There was a problem hiding this comment.
Should this also be exposed through a julia function in Base? Or is it okay to just expose the ccall like this?
@c42f: Are you the expert now on what "public" / "exported" means?
There was a problem hiding this comment.
I think keeping it a ccall is fine
|
I think the PR is fine (aside from the test that Nathan mentioned), but not that you could also export the global and then access it from Julia directly, |
vtjnash
added
the
status:merge me
DilumAluthge
added
needs tests
|
@vchuravy I don't think we can |
…ny param (not the old style)
NHDaly
force-pushed
the
aa-export-numstacks-counter
branch
from
8f1f4ad
to
ab68148
Compare
NHDaly
added
status:merge me
|
Thanks all. Sorry for the delay here. I've added a test, so this should be ready to go. Please merge as soon as tests are green! Thank you |
NHDaly
added a commit
to RelationalAI/julia
that referenced
this pull request
Sep 20, 2023
Export num_stack_mappings to track the number of in-flight stack mappings and tasks in application JuliaLang#51301
NHDaly
force-pushed
the
aa-export-numstacks-counter
branch
from
ab68148
to
982e38c
Compare
We can, but I don't think we have specified if Julia and C agree on the data layout |
adnan-alhomssi
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Sep 20, 2023
Export num_stack_mappings to track the number of in-flight stack mappings and tasks in application JuliaLang#51301
DilumAluthge
removed
the
status:merge me
kpamnany
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Oct 19, 2023
…pings and tasks in application (JuliaLang#51301)
DelveCI
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Oct 20, 2023
…pings and tasks in application (JuliaLang#51301)
kpamnany
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Oct 21, 2023
…pings and tasks in application (JuliaLang#51301)
kpamnany
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Oct 21, 2023
…pings and tasks in application (JuliaLang#51301)
DelveCI
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Jan 17, 2024
…pings and tasks in application (JuliaLang#51301)
DelveCI
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Jan 18, 2024
…pings and tasks in application (JuliaLang#51301)
DelveCI
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Jan 23, 2024
…pings and tasks in application (JuliaLang#51301)
DelveCI
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Jan 24, 2024
…pings and tasks in application (JuliaLang#51301)
DelveCI
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Jan 25, 2024
…pings and tasks in application (JuliaLang#51301)
DelveCI
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Jan 27, 2024
…pings and tasks in application (JuliaLang#51301)
DelveCI
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Jan 30, 2024
…pings and tasks in application (JuliaLang#51301)
DelveCI
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Jan 31, 2024
…pings and tasks in application (JuliaLang#51301)
DelveCI
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Feb 1, 2024
…pings and tasks in application (JuliaLang#51301)
DelveCI
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Feb 6, 2024
…pings and tasks in application (JuliaLang#51301)
DelveCI
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Feb 7, 2024
…pings and tasks in application (JuliaLang#51301)
DelveCI
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Feb 14, 2024
…pings and tasks in application (JuliaLang#51301)
DelveCI
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Feb 21, 2024
…pings and tasks in application (JuliaLang#51301)
DelveCI
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Feb 22, 2024
…pings and tasks in application (JuliaLang#51301)
Drvi
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Feb 28, 2024
…pings and tasks in application (JuliaLang#51301)
DelveCI
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Mar 1, 2024
…pings and tasks in application (JuliaLang#51301)
DelveCI
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Mar 13, 2024
…pings and tasks in application (JuliaLang#51301)
Drvi
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Apr 3, 2024
…pings and tasks in application (JuliaLang#51301)
d-netto
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Apr 16, 2024
…pings and tasks in application (JuliaLang#51301)
DelveCI
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Apr 23, 2024
…pings and tasks in application (JuliaLang#51301)
DelveCI
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Apr 24, 2024
…pings and tasks in application (JuliaLang#51301)
DelveCI
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Apr 30, 2024
…pings and tasks in application (JuliaLang#51301)
DelveCI
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Apr 30, 2024
…pings and tasks in application (JuliaLang#51301)
DelveCI
pushed a commit
to RelationalAI/julia
that referenced
this pull request
May 2, 2024
…pings and tasks in application (JuliaLang#51301)
DelveCI
pushed a commit
to RelationalAI/julia
that referenced
this pull request
May 9, 2024
…pings and tasks in application (JuliaLang#51301)
DelveCI
pushed a commit
to RelationalAI/julia
that referenced
this pull request
May 19, 2024
…pings and tasks in application (JuliaLang#51301)
DelveCI
pushed a commit
to RelationalAI/julia
that referenced
this pull request
May 26, 2024
…pings and tasks in application (JuliaLang#51301)
DelveCI
pushed a commit
to RelationalAI/julia
that referenced
this pull request
May 28, 2024
…pings and tasks in application (JuliaLang#51301)
DelveCI
pushed a commit
to RelationalAI/julia
that referenced
this pull request
May 29, 2024
…pings and tasks in application (JuliaLang#51301)
Drvi
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Jun 7, 2024
…pings and tasks in application (JuliaLang#51301)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Julia already tracks the number of mapped stacks for Julia tasks in a local atomic.
Exporting this atomic will allow applications to estimate the memory consumption by the stacks and also the number of in-flight tasks.