Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split KMM into two separate estimators KMM and uKMM #37

Closed
juliohm opened this issue Mar 4, 2020 · 2 comments
Closed

Split KMM into two separate estimators KMM and uKMM #37

juliohm opened this issue Mar 4, 2020 · 2 comments
Assignees
@xukai92
Labels
enhancement New feature or request

Comments

@juliohm
Copy link
Member

juliohm commented Mar 4, 2020 •
edited
Loading

As we discussed on the PR, it would be nice to have these two as separate methods.

@xukai92 would you like to take care of this since you seem to be using KMM the most in your research?
@juliohm juliohm added the enhancement New feature or request label Mar 4, 2020
@xukai92
Copy link
Collaborator

xukai92 commented Mar 4, 2020

Sure. It's on me.

xukai92 pushed a commit that referenced this issue Jun 13, 2022
feat: split KMM into KMM and uKMM (#37)
8082eb9
@xukai92 xukai92 mentioned this issue Jun 13, 2022
Merged
juliohm pushed a commit that referenced this issue Jun 13, 2022
@xukai92
feat: split KMM into KMM and uKMM (#37) (#44)
9853374 
* feat: split KMM into KMM and uKMM (#37)

* chore: remove @Nograd for removed function

Co-authored-by: Kai Xu <contact@xuk.ai>
@juliohm
Copy link
Member Author

juliohm commented Jun 13, 2022

Fixed on master.

@juliohm juliohm closed this as completed Jun 13, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xukai92 xukai92

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@juliohm @xukai92