For conversion of scale vector in adjoint #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It always defines an `Array` which can fail on the GPU. This forces it to be the right type. One could also use `adapt` here, but since the element type promotion would have to occur anyways in the subsequent broadcast it seems you might as well convert all at once.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #105 +/- ##
==========================================
+ Coverage 87.08% 87.32% +0.24%
==========================================
Files 3 3
Lines 209 213 +4
==========================================
+ Hits 182 186 +4
Misses 27 27
☔ View full report in Codecov by Sentry. |
stevengj
reviewed
Jun 11, 2023
|
LGTM, aside from CI failures. (Unrelated?) |
|
Looks like those are inference errors from v1.9 that inferred well on v1.8. But those tests that are failing don't call AD so it should be unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It always defines an
Arraywhich can fail on the GPU. This forces it to be the right type. One could also useadapthere, but since the element type promotion would have to occur anyways in the subsequent broadcast it seems you might as well convert all at once.