Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for julia-invalidations #287

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

kimikage
Copy link
Collaborator

@kimikage kimikage commented Apr 14, 2024

This is very ugly, but it is better than not being able to use the check.

xref: julia-actions/julia-invalidations#17

Another possible method is to use git, but directly overwriting ”Project.toml” is simpler and somewhat more reliable.

Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.05%. Comparing base (6457345) to head (e8b15e7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #287   +/-   ##
=======================================
  Coverage   97.05%   97.05%           
=======================================
  Files           7        7           
  Lines         782      782           
=======================================
  Hits          759      759           
  Misses         23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kimikage
Copy link
Collaborator Author

kimikage commented Apr 14, 2024

BTW, the output does not seem very practical.
We may need a few more practical test scripts that could happen in the downstream packages.

@kimikage kimikage merged commit 37e83e7 into JuliaMath:master Apr 18, 2024
20 checks passed
@kimikage kimikage deleted the invalidations_workaround branch April 18, 2024 11:36
@kimikage kimikage mentioned this pull request Apr 30, 2024
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant