Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake Changes #299

Merged
merged 4 commits into from
Jun 25, 2024
Merged

CMake Changes #299

merged 4 commits into from
Jun 25, 2024

Conversation

theoparis
Copy link
Contributor

@theoparis theoparis commented Mar 15, 2024

  • Removing SHARED allows openlibm to be built statically depending on the value of BUILD_SHARED_LIBS
  • Using CMAKE_CURRENT_SOURCE_DIR allows openlibm to be built via FetchContent
  • I added the riscv64 architecture to openlibm's cmake build scripts

@ViralBShah
Copy link
Member

Merge?

@ViliusSutkus89 ViliusSutkus89 mentioned this pull request Jun 17, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.02%. Comparing base (4b83beb) to head (a1fdd7c).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
+ Coverage   38.24%   39.02%   +0.78%     
==========================================
  Files         233      233              
  Lines        6139     6144       +5     
  Branches     1607     1607              
==========================================
+ Hits         2348     2398      +50     
+ Misses       3394     3393       -1     
+ Partials      397      353      -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theoparis theoparis marked this pull request as ready for review June 19, 2024 20:50
@ViralBShah ViralBShah closed this Jun 19, 2024
@ViralBShah ViralBShah reopened this Jun 19, 2024
@ViralBShah
Copy link
Member

Can you rebase to master? Is this ok to merge given the changes in #302? It looks like there is no conflict.

@ViliusSutkus89 ViliusSutkus89 merged commit d66f477 into JuliaMath:master Jun 25, 2024
32 of 34 checks passed
@ViliusSutkus89
Copy link
Collaborator

Hello @theoparis , could you confirm that the current git version works for you with FetchContent?

Also, if you don't mind me asking, have you tried using package managers instead of FetchContent? I'm assuming you're using it to pull OpenLibm into your project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants