Minor fix-ups for Darwin PowerPC #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #303 +/- ##
==========================================
+ Coverage 38.24% 39.02% +0.78%
==========================================
Files 233 233
Lines 6139 6144 +5
Branches 1607 1608 +1
==========================================
+ Hits 2348 2398 +50
+ Misses 3394 3393 -1
+ Partials 397 353 -44 ☔ View full report in Codecov by Sentry. |
|
Windows is trying to use gcc instead of clang. Otherwise, happy to merge. |
|
@ViralBShah Thanks for merging! This was super-fast. |
|
Would you like me to tag a new release? |
That would be certainly helpful, thank you. |
|
Released 0.8.3 |
Updated in MacPorts in macports/macports-ports@9e47870 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ViralBShah This took forever :) Sorry for a ridiculous delay, it was forgotten.
Here are two tiny fixes:
ppc64, so that it is not left broken on macOS. (BTW, this still leaves out AIX, I believe?)__BYTE_ORDER__is actually defined: AFAIK, it may not be the case with some old gcc versions, and those support C99, so it is relevant.