Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New home for @require_extensions? #114

Closed
cjdoris opened this issue May 22, 2023 · 2 comments
Closed

New home for @require_extensions? #114

cjdoris opened this issue May 22, 2023 · 2 comments

Comments

@cjdoris
Copy link

cjdoris commented May 22, 2023 •
edited
Loading

C.f. cjdoris/PackageExtensionCompat.jl#1, I have a macro @require_extensions which is a no-op on Julia 1.9 but uses @require to load package extensions on earlier versions of Julia. This provides some backwards-compatibility for package extensions.

It seems to me that Requires.jl is a good home for this macro. I can make a PR to move it here if you like?
@vchuravy
Copy link
Member

I would be okay with that.

cc: @timholy @KristofferC

@longemen3000 longemen3000 mentioned this issue May 30, 2023
Closed
@cjdoris
Copy link
Author

cjdoris commented Jun 22, 2023

I've decided this is better in its own package, because then it can avoid loading Requires.jl at all on v1.9+.

@cjdoris cjdoris closed this as completed Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vchuravy @cjdoris