-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PackageExtensionTools.jl #55
Comments
i would recommend to wait until the code is merged into |
@longemen3000 you mean that PackageExtensionTools.jl will be merged into Requires.jl? |
i suppose, check JuliaPackaging/Requires.jl#114 |
Can we use PackageExtensionTools.jl now on this package as an example? It
seems that the Requires.jl PR was merged.
Em ter., 30 de mai. de 2023 12:09, Andrés Riedemann <
***@***.***> escreveu:
… i suppose, check JuliaPackaging/Requires.jl#114
<JuliaPackaging/Requires.jl#114>
—
Reply to this email directly, view it on GitHub
<#55 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZQW3J4PK2C4KMS3M4FRE3XIYER3ANCNFSM6AAAAAAYS2LLNQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@longemen3000 what is the status quo now for these extension packages? |
Now that it is merged, it is possible to give it a try |
@longemen3000 can you kindly help here again converting the manual approach to the new recommended approach with PackageExtensionCompat.jl? Is that the newest recommended approach? |
let me ask, the main problem in this particular package is that some extensions require 2 external packages loaded (JuMP + IPOPT, for example) i don't know if that package supports that specific workflow |
This package requires 2 packages as you described. Does it mean that we
need to preserve the current approach? What if we drop support for Julia <
1.9, can we simplify the code organization?
Em seg., 3 de jul. de 2023 17:00, Andrés Riedemann ***@***.***>
escreveu:
… let me ask, the main problem in this particular package is that some
extensions require 2 external packages loaded (JuMP + IPOPT, for example) i
don't know if that package supports that specific workflow
—
Reply to this email directly, view it on GitHub
<#55 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZQW3NE3Q35NUI3M2UZCVLXOMQGNANCNFSM6AAAAAAYS2LLNQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
if you drop julia < 1.9, then you can drop requires too |
@longemen3000 could you help with a quick PR that drops Julia < v1.9 support? I will try to read the package extensions docs by the end of the week, but I am assuming that this specific case with DensityRatioEstimation.jl and its optional functionality that depends on multiple packages is a tricky case to get right. |
wait a moment, i'll do it right now |
Fixed on master. |
Refactor the code to use https://github.com/cjdoris/PackageExtensionTools.jl
The text was updated successfully, but these errors were encountered: