Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: MzXML v0.1.0 #22166

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Sep 29, 2020

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2020

Your new package pull request met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

Since you are registering a new package, please make sure that you have read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@timholy
Copy link
Member

timholy commented Sep 29, 2020

This is an ancient repository that I've updated to Julia 1. However, I'm a little unsure what to do about the name. The package supports the mzXML file format, which is usually seen with a lowercase m.

I'm open to changing the name; would mzXMLFormat.jl be preferable as conveying that the package implements a file format?

@aviks
Copy link
Contributor

aviks commented Sep 29, 2020

I personally think this name is relevant here.

@rfourquet
Copy link
Contributor

I would favor sticking to the Julia convention, like the Random.dSFMT module was renamed to DSFMT (#JuliaLang/julia#25567).

@StefanKarpinski
Copy link
Contributor

MzXML perhaps?

@timholy
Copy link
Member

timholy commented Oct 1, 2020

The preferences seem pretty evenly split. As I've begun using this package again, I am contemplating using the uppercase M. Do new packages require a manual merge, or is the 3-day thing automatic? Just wondering how long I have to decide.

@fredrikekre
Copy link
Member

Just comment when you have made a decision, it is not automatic.

UUID: cb69de98-8f9f-5947-b504-cdcc19a34020
Repo: https://github.com/timholy/MzXML.jl.git
Tree: e48c1a75d717d87b1c787f719499bbfd8300c758

Registrator tree SHA: e934b8c55381f28735124f23e8f7e96d09b20416
@JuliaRegistrator JuliaRegistrator changed the title New package: mzXML v0.1.0 New package: MzXML v0.1.0 Oct 2, 2020
@JuliaRegistrator JuliaRegistrator force-pushed the registrator/mzxml/cb69de98/v0.1.0 branch from 006e813 to db391cb Compare October 2, 2020 10:42
JuliaRegistrator referenced this pull request in timholy/MzXML.jl Oct 2, 2020
Rename package and add many new features
@timholy
Copy link
Member

timholy commented Oct 2, 2020

I went with MzXML. Thanks for the feedback, all!

@fredrikekre fredrikekre merged commit f3e37ea into master Oct 2, 2020
@fredrikekre fredrikekre deleted the registrator/mzxml/cb69de98/v0.1.0 branch October 2, 2020 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants