Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for NLopt 1.0 #706

Merged
merged 4 commits into from
Aug 20, 2023
Merged

support for NLopt 1.0 #706

merged 4 commits into from
Aug 20, 2023

Conversation

palday
Copy link
Member

@palday palday commented Aug 19, 2023

This bumps NLopt support for the 1.0 release, which moves MathOptInterface support to an extension. This dramatically improves load times for MixedModels, which doesn't need MathOptInterface. I've dropped support for NLopt 0.5 because the callbacks don't work on Julia 1.5+ (due to the stack allocation of immutable structs -- the struct was changed to mutable in 0.6), since we're already compat bounded to Julia 1.8.

  • I've bumped the version appropriately

@palday palday requested a review from dmbates August 19, 2023 16:39
@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (c9dbaf6) 95.83% compared to head (c0553ee) 95.83%.

❗ Current head c0553ee differs from pull request most recent head 41469c8. Consider uploading reports for the commit 41469c8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #706      +/-   ##
==========================================
- Coverage   95.83%   95.83%   -0.01%     
==========================================
  Files          35       35              
  Lines        3266     3263       -3     
==========================================
- Hits         3130     3127       -3     
  Misses        136      136              
Flag Coverage Δ
current 95.83% <ø> (-0.01%) ⬇️
minimum 95.72% <ø> (-0.01%) ⬇️
nightly 95.83% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palday palday requested a review from ararslan August 19, 2023 17:51
@palday
Copy link
Member Author

palday commented Aug 19, 2023

image

@dmbates
Copy link
Collaborator

dmbates commented Aug 20, 2023

I may have done the approvals of PR's backwards. I approved and committed the PR that bumps the version to 4.18.0 whereas this PR bumps the version to 4.17.1. Should that be changed now to 4.18.1? I haven't alerted the JuliaRegistrator to the version bump to 4.18.0

Update version to 4.18.1, not 4.17.1
@palday
Copy link
Member Author

palday commented Aug 20, 2023

@dmbates we can just roll them together into a single release as 4.18.0.

@palday palday merged commit 66ec87d into main Aug 20, 2023
7 checks passed
@palday palday deleted the pa/nlopt_07 branch August 20, 2023 14:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants